I would like to take over the project and apply the patches given... It is clear the project has not received any attention to it, so I would like to fire it up and give it a breath of air. I don't plan on changing the database or the fundamentals to keep it compatible with the 6.x path upgrade. However I have posted a completed fix that incorporates all the changes the users have submitted (except for one). Please respond to this as the project appears to be abandoned

patch
http://drupal.org/node/289780#comment-945539

rules for taking over a project
http://drupal.org/node/251466

Comments

sonicthoughts’s picture

sonicthoughts commented

for what it's worth - you definitely have my vote, but please don't let this become a branch that competes with the Amazon module .too.

Prometheus6’s picture

Prometheus6 commented

I got no problem with it.

eaton’s picture

eaton commented

I'd be interested in touching base with you about best approaches for cooperation between the 'Amazon' project and this one...

mcurry’s picture

mcurry commented

Subscribe

I support anything that will move this module forward.

Please let me know how I can help. This module is important to some of my sites...
I can help with testing and HTML/CSS/PHP coding. (I've submitted patches in the past,)

MGParisi’s picture

MGParisi commented

I planned on applying small changes and patches. I really don't have time to take over a project but I figured since this is being neglected and that their were GREAT patches out, I would put them together. I then started cleaning up the HTML, but that has some problems, and I don't know how I should go foreword because it will force people to apply new style to the module. I wasn't going to add features or anything but I still need to gain CVS access and figure out that! I am excited by all the energy here! I will consult the dev team on how to move foreword the best!

MGParisi’s picture

MGParisi commented

I put the patches together and did a few new things. I cant seem to figure out the code too much. His XML parser is great, but I don't have a 4.X machine! I would essentially drop 4.x Support. After that I would have to basically re-write most of it. Not because the original author did a bad job, but because the lack of notes and the complexity of the issues at hand are great. I would love to take over this project but I just cant promise the type of response I would want from someone maintaining a project. Instead I zipped up the fixes and changes and I put it in the linked post

http://drupal.org/node/289780#comment-948362

I would love to see this break out of simple books and accept any item, I would love it to update prices and delete items no longer offered. However I just cant responsibly do this. I will help out anyone who decides to do some more work. I would support you inactivist. You seem much more adapt at reading other peoples code then I am. I need to create my first module from the ground up, or else I will be over my head. I just have too much trouble reading non-oop code of this complexity!

Sorry
Mike

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I'm nervous about re-writes and things like that... Amazon module is the way forward for 6.x+. This module should really only be in "maintenance mode" for the remainder of the 5.x lifecycle. It's cool to fix bugs and such, but re-writing XML parsers and fiddling with the database schema means breaking the upgrade path to Amazon module, and that would harm a bunch of users.

MGParisi’s picture

MGParisi commented

I agree, I know that there are people here that can upgrade the module using the current code, but I personally would have to go through and re-write the amazon.module, which is not the parser, but it is the display and logic. There is a amazon.inc, which is a part of the parser. Then there is the php4 and php5 files that handle the parsing, and various amazon inc's.

The only thing I noticed was set widths on images that I never saw a need to have set. They were set widths on the images and they went into the database. I have removed these with no ill consequences seen so far.

The logic is tied in with allot of the theme's, and their is almost no function documentation on the module itself, so I am just not the guy to do it. I have NO doubt seeing in activists patch and working with it that he can do the job.

mcurry’s picture

mcurry commented

I have NO doubt seeing in activists patch and working with it that he can do the job.

*blush* thank you for the vote of confidence.

While I'm sure I can help fix bugs and do minor cleanup, I'm quite busy and already in a bit 'hot water' for not being active enough in fixing some of my own modules (see the issues queue for adsense_injector, ed_readmore, ed_classified, etc.) so I can't take on any major new efforts. I will help fix bugs (if I can reproduce them) and roll patches to this module though.

I vote for not rewriting this module, and not removing PHP4 support- eliminating PHP4 support would create problems for existing module users. I'm sure that dropping PHP4 support can make developers' lives easier, I think it's a mistake to pull the rug out from existing module users by suddenly dropping existing PHP4 support. Not everyone can update their hosting plans to PHP4 at the blink of an eye...

I'm nervous about re-writes and things like that... Amazon module is the way forward for 6.x+. This module should really only be in "maintenance mode" for the remainder of the 5.x lifecycle. It's cool to fix bugs and such, but re-writing XML parsers and fiddling with the database schema means breaking the upgrade path to Amazon module, and that would harm a bunch of users.

I"m not sure why we're considering major changes to this module. It certainly needs some tender loving care, and the coding style isn't what I expect, but the basic module works, doesn't it? So I, too, vote for just doing maintenance on the module. I will help with that, for sure. I won't be able to assist with a major restructuring or refactoring.

mcurry’s picture

mcurry commented

I would support you inactivist. You seem much more adapt at reading other peoples code then I am.

Again, thanks for the kind words. I'm willing to consider helping maintain this module, under these conditions:

  1. The module is in maintenance mode (bug fixing) only from now on. No refactoring, rewriting, new features, etc. This may mean that MGParisi's recent work cannot be used...?
  2. I may be unable to fix bugs I can not reproduce, and I have limited ability to test the module, so I may not be able to reproduce any particular bug. If I can't reproduce a bug, and I can't figure out the cause based on the feedback given, then the community will have to help (debug and submit patches), which I will evaluate and integrate into the module when I have time.
  3. I'm busy. You wouldn't believe how busy I am. Did I say I was busy? I have a 'day job' which doesn't allow me to spend much time on Drupal module development or maintenance, and when I'm not working the day job, I'm maintaining my existing web site projects - this leaves me with little time. Therefore, I tend to focus on fixing the problems that I encounter (I've submitted several patches to this module for that very reason). If there are other fixes wanted, the community will need to be patient or pitch in and do their own debugging and patches (which I will gladly evaluate and integrate as appropriate), in order to expedite fixes.

Now, having said all that, if someone wants to grant me CVS access to this module, I'll start trying to help as soon as possible. And there's no reason why this module can't have multiple co-maintainers -- so please, if anyone else in the viewing audience can pitch in and serve as a co-maintainer, please speak up!

MGParisi’s picture

MGParisi commented

Eaton is using the Height and Width elements of the module, so don't include my LAST upgrade. I will package a upgrade that is responsible and post it.

MGParisi’s picture

MGParisi commented

I have posted a more "responsible" upgrade. Is changing the original theme call a deal breaker? If so, I can make changes that will keep my changes but will prevent issues for thoose who have over-ridden the original theme functions.

MGParisi’s picture

MGParisi commented

The Project Mentions a ASBN number, but this is difficult to find. In truth it should be the ISBN number. Does anyone object to changing the upgrade I have created to reflect this change?

jbrauer’s picture

jbrauer commented

@MGParisi Think it should be an ASIN number instead of ISBN or ASBN. For books ASIN = ISBN-10 but for other products it isn't an ISBN but an Amazon assigned number.

AjK’s picture

AjK commented

#2 acknowledged, project transferred.

MGParisi’s picture

MGParisi commented

I think there are some problems with it... personally I think it should state ASIN/ISBN-10... If you search amazon it says ISBN and rarely ASIN... Today was the first day I saw ASIN on amazon item..

I think this language is important as a UI issue, and am putting together a big patch.

entendu’s picture

entendu commented

I'm basically re-implementing this for a client. I positioned myself to be able to write it up in a very generic way. There's a lot I've implemented that I haven't seen talked about at all that will make it a snap to use and configure (d5 only thus far).

I'll be releasing it in the next day or two.

MGParisi’s picture

MGParisi commented

I have taken over the project but only to help facilitate the community and to hopefully fix some bugs, though it may take some time. I would love to see your changes. I wish I knew about 10 minutes ago when I got CVS access for this project. I would of offered you the position!

MGParisi’s picture

MGParisi commented

I have done an upgrade to the module, lets hope it works like its suppose to, this is my first CVS upgrade. There is NO changes to the data structure. The "Backwords" compatibility doesn't exist yet, and if anything changed from that time till now, my patch will not break it.

Basically my patch fixes some minor issues.

jbrauer’s picture

jbrauer commented

ASIN/ISBN-10 would make sense. At least as far as I can see there are pages that only list one or the other as field names so it would help with usability.

MGParisi’s picture

MGParisi commented

Beyond our control, someone has made a CCK version of a Amazon tools and is going to progress it. That will split this project, and honestly make this project out of date. I am debating publishing my updates because they change the style of the amazon module a bit. If you built custom theme elements or copy the old ones and put them in your template.tpl.php it will remain the style it is.

eaton’s picture

eaton commented

Beyond our control, someone has made a CCK version of a Amazon tools and is going to progress it.

Do you mean the ASIN module, at http://drupal.org/project/asin ? It's been around for quite some time...

MGParisi’s picture

MGParisi commented

Its in reference to

dsantangelo - August 21, 2008 - 00:16

I'm basically re-implementing this for a client. I positioned myself to be able to write it up in a very generic way. There's a lot I've implemented that I haven't seen talked about at all that will make it a snap to use and configure (d5 only thus far).

I'll be releasing it in the next day or two.

There is no upgrade path from the Amazon Tools project to that project, and there is no upgrade path to your project. We at 5.x are stuck... Everyone acknowledges your work, and wants the features and effort you put into it. But we (5.x) don't have a viable solution and for some of us this is one way we plan on making money. Which is VERY important, lol! I need a solution for 5.x, and Amazon tools is nice it has some MAJOR draw backs. I can assure you no one wants another Amazon project, but it will be crazy not to allow dsantangelo to release a module he has already written.

This unfortunately does not end happily ever after for all of us involved and ends up with multiple products. I have decided to look at his project and if it meets my needs better then I GOT to use it:( I do plan on releasing the HEAD version, but I have another contribution to make that will solve some theme related issues for those who have over-ridden this modules functions.

Basically my update shouldnt break anything except custom CSS code, and that is not a happy situation either. However it fixes allot in Amazon tools.

Mike

entendu’s picture

entendu commented

An upgrade path would be very very useful.

I want to be clear on this point: my intention was not to usurp an existing module. AAT just didn't have what we needed on the client side, and with a marginal amount of extra effort I was able to abstract the client's product to something the whole community could use. Also, at the time that I started, AAT didn't have an active maintainer. The project page (http://drupal.org/project/import_aws) has a good deal of information about what makes it unique in this area.

With community support, I'd like to continue to actively develop this. It was created with the intention to make its users money in one way or another (either through giving you content, or associate payments, or both).

Since I already wrote this module for a client, and it has the support of both me and the shop (WorkHabit), I recommend we proceed with an upgrade path from this module to mine.

MGParisi’s picture

MGParisi commented

Some of us need these modules to keep our site alive. If that means a fork or an improvement then I am for it! I need money to make the site run! Its as simple as that! I am great full that you took a already existing application and gave it to the community. You didn't have to do that and the work you have sent me for review and such has been amazing. You step it up and go that extra mile. I cant complain. Sometimes our private work can be applied to the public community. If Drupal members reject this work then they will be killing an incredible resource. I dont think anyone who knows anything about open source will complain. What drives Open Source applications is Commercial and Public Development. We must keep that in mind when looking at duplicate projects.

Amazon Tools is a great easy to use product that has some good things to it. But it is not a CCK/Views based project. That hurts it for it is not as flexible. One thing AT has is the widget that can be added to other Content Types. (related books) to an article or someones post is a great way to build revenue. I need to setup your project and give it a full analysis. I am going to be doing that this night after I do some other transformations to the site.

Mike

MGParisi’s picture

MGParisi commented
Status: Active » Closed (fixed)

new version released closing support request