Problem/Motivation

This module should be updated for Drupal 10, at least we should update jquery.once library with drupal/once library:
https://www.drupal.org/node/3158256

We need to change core_version_requirement to ^9.2 || ^10, becuase javascript once() was added only in 9.2 Drupal core:

Issue fork allowed_languages-3330330

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

levmyshkin created an issue. See original summary.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented

Hi, I replaced jQuery once with javascript once in 3330330-drupal-10-support branch.

I changed core_version_requirement to ^9.2 || ^10, becuase javascript once() was added only in 9.2 Drupal core:
https://www.drupal.org/node/3158256

Also here is another problem with Event Subscriber, which I will see later:
Fatal error: Declaration of Drupal\allowed_languages\Routing\AllowedLanguagesRouteSubscriber::getSubscribedEvents() must be compatible with Drupal\content_translation\Routing\ContentTranslationRouteSubscriber::getSubscribedEvents(): array in /home/laptop/projects/drupal10/web/modules/custom/allowed_languages/src/Routing/AllowedLanguagesRouteSubscriber.php on line 28

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Active » Needs work

harshitthakore made their first commit to this issue’s fork.

harshitthakore’s picture

harshitthakore
Primary language English
Location Ahmedabad
commented
Status: Needs work » Needs review

Fixed compatibility, highlighted in comment #2

harshitthakore opened merge request !1

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Assigned: levmyshkin » Unassigned

heddn made their first commit to this issue’s fork.

  • heddn committed dff4aede on 2.x 
    Issue #3330330 by levmyshkin, harshitthakore, heddn: Drupal 10 Support
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for all your work here. I tested this locally in a vanilla d10 site. The once js stuffs just works. The tests were failing, but they are now passing again. This looks great.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.