Not compatible with jQuery Update (needs to use drupal_add_library() instead of drupal_add_js()) [#1312330]

This results in AJAX forms failing. Other modules which I use and which may be interfering with JQuery update:

ctools
boxes
ajax_poll
views
(result of grep -ro 'jquery.form').

Please tell me if there's some additional information I can provide.

Comment	File	Size	Author
#3	use_drupal_add_library_in_ajax_poll-1312330-3.patch	597 bytes	westwesterson

Comments

Comment #1

quicksketch

he/him

commented 21 September 2012 at 00:38

Title:

JQuery update includes jquery.form in some cases

» JQuery update does not include jquery.form in some cases

I think I have confirmed this problem. The JavaScript console reports:

Uncaught TypeError: Object function (a,b){return new d.fn.init(a,b,g)} has no method 'handleError'

In the jquery.form.js file. As reported in http://stackoverflow.com/questions/6774231/jquery-form-plugin-uncaught-t..., this is because the stock version of jquery.form.js version we're using it not compatible with jQuery 1.5+. It looks like jQuery Update is supposed to be including the newer version of the file for us, but it's not.

jquery.form.js has been added to the page via drupal_add_js('misc/jquery.form.js'); in my situation (and probably in AJAX Poll module since I maintain that module too).

Comment #2

quicksketch

he/him

commented 21 September 2012 at 00:40

Title:	JQuery update does not include jquery.form in some cases	» Not compatible with jQuery Update (needs to use drupal_add_library() instead of drupal_add_js())
Project:	jQuery Update	» AJAX Poll
Version:	7.x-2.2	» 7.x-1.1

Ah, well looks like this is my fault. In order to be compatible with jQuery Update, modules must (and should anyway) be using drupal_add_library() instead of drupal_add_js(). I'll move this over to the AJAX Poll queue and handle this problem there.