Problem/Motivation

Thank you so much for making this module, it's really nice to be able to place the Navigation horizontally at the top of the page, like we can with Toolbar together with Admin Toolbar.

After installing the module at first I thought it does not work, since the Navigation was still in the left side. I then realised I had to install an extra module, and place the Navigation at the top.

Since the vast majority of users will install this module to move the Navigation to the top, perhaps the Position feature can be installed by default (moving it into "admin_navigation" I guess?) with Position set to "Top bar"?

Also, the "Top bar options" option "Hide duplicate popover headers" works flawlessly, and again I would think the majority of users would want to not show these redundant headers. So perhaps set the default to hide them?

Steps to reproduce

Install the Admin Navigation module and think it does not work, since the Admin Navigation Position module was not installed.

Proposed resolution

  1. Automatically enable the Admin Navigation Position feature, when installing the Admin Navigation module
  2. ✅ Set Position default settings to make the module work out of the box, and hide duplicate headers, with these settings?
    Navigation position
    x Top bar — Horizontal navigation at the top of the page
       Sidebar — Vertical left-aligned navigation

    Top bar options
    x Hide duplicate popover headers

Remaining tasks

User interface changes

API changes

Data model changes

Comments

ressa created an issue. See original summary.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
ressa’s picture

ressa
he/him
commented
Issue summary: View changes
ressa’s picture

ressa
he/him
commented
Issue summary: View changes
ressa’s picture

ressa
he/him
commented
Version: 1.0.0 » 1.1.1
Issue summary: View changes

Thanks for adding the two suggestions about automatically placing it at the top and hiding redundant headers in the 1.1.1 release a few days ago, it works great. (By the way, the default Gitlab version is still 1.0.x)

What do you think about the suggestion to also automatically enable the Position feature, is it possible? If moving module code around is not an option, this important information could be made clearer by adding something like this at the top of the project page?

Drupal core now ships with a modern left-aligned Navigation module that replaces the legacy Toolbar with a collapsible vertical sidebar. The original contributed module was merged into core (Drupal 10.2+ and 11) and is the foundation Admin Navigation builds on — core ships the structure, this module adds the polish.

Install the Admin Navigation and Admin Navigation Position modules to place the Navigation menu at the top.

nelo_drup’s picture

nelo_drup commented
Issue summary: View changes

New version 1.1.2

ressa’s picture

ressa
he/him
commented

Thanks for adding a warning if the Position module is not installed. Since a sub-module cannot be a dependency, this is a fine workaround.

And what do you think about my suggestion about adding a short text at the top of the project page?

Install the Admin Navigation and Admin Navigation Position modules to place the Navigation menu at the top.

And as a side note, there are some odd line breaks in the text, caused by a few stray <br>'s that can be removed.

PS. Somehow, the Issue Summary got translated into Spanish, maybe you meant to leave a comment instead? I reverted the Issue Summary, since it seemed to be a straight English > Spanish translation.