Closed (fixed)
Project:
Admin message
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2007 at 20:27 UTC
Updated:
26 Dec 2007 at 18:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
anders.fajerson commentedYes, I have definately been giving it some thought. It might not have been the best idea to disable the title. The reason you give is probably the most obvious one.
I'll look into it if I can enable it again and provide an uppgrade path.
Comment #2
amanire commented+1 It would be nice to be able to use this module in combination w/the Automatic Nodetitles module.
Comment #3
Christefano-oldaccount commentedAnother good reason for titles is so that the search module can display a title for admin messages in search results. This is something I need on a site I'm working on and when I took a look I realized that Admin message doesn't use hook_node_info().
Here's a patch that adds that. I haven't applied it on a running site to see what happens (I didn't have many admin messages so an upgrade path wasn't a big deal for me -- I just disabled Admin message, added a function, deleted the Admin message content type and re-enabled the module). Be sure to backup your messages (and related custom PHP rules) first.
Comment #4
Christefano-oldaccount commentedComment #5
anders.fajerson commentedThanks for the patch! Are you sure hook_node_info() is needed here? I was thinking of enabling the title in an update function.
Comment #6
Christefano-oldaccount commentedModules that create their own content type (like bio and usernode) are using hook_node_info() and I'm pretty sure it's needed here.
Can you say more about what you were thinking about an update function? That sounds important for a proper upgrade path.
Comment #7
anders.fajerson commentedThis should do the trick. I'm not using node_info() to implement this modules content type, instead I'm using node_type_save().
Comment #8
Christefano-oldaccount commentedI reversed the effects of my patch and gave #7 a try and it works as it should. I think this is RTBC but won't change status since I didn't have any admin_message nodes to migrate.
Amitaibu or amanire, can you review this?
Comment #9
anders.fajerson commentedI've committed a slightly altered version of this patch: http://drupal.org/cvs?commit=91152
Comment #10
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.