Comments

suresh prabhu parkala’s picture

Status: Active » Needs review
StatusFileSize
new493 bytes

Please review!

sutharsan’s picture

Status: Needs review » Needs work

Patch is ok.
Additional scan result from Upgrade Status:

FILE: modules/d9/admin_content_notification/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not Drupal 9 compatible.     
                    Either remove it or update it to be compatible with Drupal  
                    9. See                                                      
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.   
--------------------------------------------------------------------------------
suresh prabhu parkala’s picture

Status: Needs work » Needs review
StatusFileSize
new852 bytes

updated patch please review!

sutharsan’s picture

Status: Needs review » Reviewed & tested by the community
cestmoi’s picture

So is this D9 ready please ? if so why not committed yet !
Thanks

cestmoi’s picture

I downloaded and installed the module manually after applying the patch and I confirm it installs and config without errors on D9.01.
I haven't tested its functionality yet.

cestmoi’s picture

Tested on production D9 and all working fine except for the inconvenient CC of all emails recipients instead of BCC !!!

manish.upadhyay’s picture

manish.upadhyay’s picture

manish.upadhyay’s picture

Status: Reviewed & tested by the community » Fixed
manish.upadhyay’s picture

Status: Fixed » Closed (fixed)