Closed (fixed)
Project:
Active Sessions
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Dec 2013 at 22:11 UTC
Updated:
17 Jan 2014 at 22:48 UTC
Jump to comment: Most recent
Comments
Comment #1
nmcclain commentedI was able to test this across a few D7 sites - worked flawlessly!!
I didn't have a footer section, so my block was disabled upon module activation, but I think that flow makes sense and actually gives the user a little chance to know they can go configure the block.
I ran this through coder_review (no warnings), tried in on systems w/PHP 5.2, 5.3, and 5.4, and manually read through the permissions/forms/sessions code extra carefully for security red-flags. Nothing stands out to me, and this is very readable code - great work!!
Comment #2
aaronott commentedThanks for the feedback and the security review.