Problem/Motivation

Add support for Group 3.x version

Issue fork access_unpublished_group-3564641

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3.x Comparechanges, plain diff MR !7
    • 2 hidden branches
  • 3.x-fork Comparecompare
  • 3564641-support-for-group Comparecompare
About issue forks

Comments

dmundra created an issue. See original summary.

ceithamer728 made their first commit to this issue’s fork.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Version: 2.x-dev » 3.x-dev

FYI created https://www.drupal.org/project/access_unpublished_group/releases/3.x-dev branch for Group 3.x compatibility

ceithamer728 opened merge request !7

dmundra’s picture

dmundra
he/him
Primary language English
commented

Thank you @ceithamer728 I updated the composer.json version of groups to see if the tests pass.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Active » Needs work

Ah looks like we need to update the tests. Seeing this error

1) Drupal\Tests\access_unpublished_group\Functional\ContentInGroupAccessTest::testGroupEntityAccessWithValidToken
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "group_content_type" entity type does not exist.
/builds/project/access_unpublished_group/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php:139
/builds/project/access_unpublished_group/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php:260
/builds/project/access_unpublished_group/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php:192
/builds/project/access_unpublished_group/tests/src/Functional/ContentInGroupAccessTest.php:48
2) Drupal\Tests\access_unpublished_group\Functional\ContentInGroupAccessTest::testAccessWithExpiredToken
dmundra’s picture

dmundra
he/him
Primary language English
commented
Related issues: +#3494298: The "group_content_type" entity type does not exist error after upgrade from v2 to v3

dmundra changed the visibility of the branch 3.x-fork to hidden.

dmundra changed the visibility of the branch 3564641-support-for-group to hidden.

ceithamer728’s picture

ceithamer728 commented

Yep! Simple change surprisingly.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Okay merging this and then I will create a 3.x release soon.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Tested it in local version and it works.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)
dmundra’s picture

dmundra
he/him
Primary language English
commented

Release https://www.drupal.org/project/access_unpublished_group/releases/3.0.0 created