move content_type settings setup from i18n form to the publishing options form

needs testing.

CommentFileSizeAuthor
#5 interdiff_3_to_5_issue-2922316.txt722 bytesjoseph.olstad
#5 entity_translation_unified_form_move_settings-2922316-5.patch1.88 KBjoseph.olstad
#3 entity_translation_unified_form_move_settings-2922316-3.patch1.9 KBjoseph.olstad
#2 entity_translation_unified_form_move_settings-2922316-2.patch2.01 KBjoseph.olstad

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new entity_translation_unified_form_move_settings-2922316-2.patch2.01 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new entity_translation_unified_form_move_settings-2922316-3.patch1.9 KB

try this patch instead.

bzaher’s picture

bzaher commented
Status: Needs review » Needs work

The second patch is nearly there, though I believe the states array must refer to the language_content_type field instead:

$states = array(
    'visible' => array(
      ':input[name="language_content_type"]' => array('value' => ENTITY_TRANSLATION_ENABLED),
    ),
  );
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
StatusFileSize
new entity_translation_unified_form_move_settings-2922316-5.patch1.88 KB
new interdiff_3_to_5_issue-2922316.txt722 bytes

Ok, good catch, this should work provided that the ENTITY_TRANSLATION_ENABLED const value is set , which I'm guessing it would be.
see new patch and the interdiff from patch 3 to patch 5.

  • bzaher committed 37f988f on 7.x-1.x 
    Issue #2922316 by joseph.olstad: move content_type settings setup from...
bzaher’s picture

bzaher commented
Status: Needs review » Fixed

The patch looks good. Tested and committed.

bzaher’s picture

bzaher commented
Version: » 7.x-1.x-dev
Status: Fixed » Closed (fixed)