We should add a final hook just before the values are uploaded in the transpose() function so that other modules can modify them before they go out.

CommentFileSizeAuthor
#9 add_hook_to_alter-2869041-9.patch2.03 KBshabana.navas
#7 amazon_mws_add-hook-to-alter-variation-values_2869041_7.patch1.18 KBshabana.navas
#4 amazon_mws_add-hook-to-alter-variation-values_2869041_4.patch1.16 KBshabana.navas
add-hook-to-alter-variation-values_2629252_1.patch1.16 KBshabana.navas

Comments

shabana.navas created an issue. See original summary.

shabana.navas’s picture

shabana.navas commented

-

shabana.navas’s picture

shabana.navas commented
Issue summary: View changes
shabana.navas’s picture

shabana.navas commented
StatusFileSize
new amazon_mws_add-hook-to-alter-variation-values_2869041_4.patch1.16 KB
travis-bradbury’s picture

travis-bradbury commented
Status: Needs review » Needs work 
+++ b/classes/commerce_amazon_mws.Mapping.php
@@ -115,6 +117,8 @@ class CommerceAmazonMWSTypeMapping {
+            drupal_alter('amazon_mws_variation_value', $value, $amazon_field_key, $drupal_field_key);

Should this be `amazon_mws_node_value` instead of variation_value? Or, if we're just doing one alter hook, should we pass in other information like the entity type or the entity itself?

shabana.navas’s picture

shabana.navas commented

Yeah, good suggestion there @tbradbury. Since we're passing in most of the info already, it would be nice to pass in the entity itself as well. I'll go ahead and submit another patch with those changes.

shabana.navas’s picture

shabana.navas commented
StatusFileSize
new amazon_mws_add-hook-to-alter-variation-values_2869041_7.patch1.18 KB

Updated patch. Changes added from recommendations in #5.

shabana.navas’s picture

shabana.navas commented
Status: Needs work » Needs review
shabana.navas’s picture

shabana.navas commented
StatusFileSize
new add_hook_to_alter-2869041-9.patch2.03 KB
mbreden’s picture

mbreden commented

On the latest patch (-9), the second

drupal_alter('amazon_mws_variation_value', $value, $amazon_field_key, $drupal_field_key, $variation);

Will/might have an undefined $variation variable.