For every file in core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Plugin/migrate/source/d6 which implements RequirementsInterface

  1. Inside @MigrateSource add a comma to the end of the id line
  2. add the relevant source_provider = "modulename" line
  3. remove implements RequirementsInterface.
  4. remove use Drupal\migrate\Plugin\RequirementsInterface; (the example missed this)
  5. remove the checkRequirements method.
CommentFileSizeAuthor
#5 imp-2202023-3.patch18.94 KBbdone
#2 changes.txt1.18 KBchx

Comments

marvil07’s picture

marvil07 commented

I'm a little confused, so hopefully someone can help me to understand.

2. what would modulename would be meaning? the drupal origin module with related functionality/schema or the module that provides the migrate source? if origin module, it would be too specific, since it will work only with drupal sources, right?, so I guess is the second alternative, which the only use I can think for it now would be to help instrospect the plugin.

This seems to not be about removing RequirementsInterface, but change its use on d6 migrate source plugins, and that sounds fine, but I still would like to know how the explained steps can replace what should be done(not sure if on migrate executer we are yet using RequirementsInterface) via that interface.

chx’s picture

chx commented
StatusFileSize
new changes.txt1.18 KB

Sorry I forgot to add the example file. Hope this clarifies! The modulename comes from checkRequirements.

bdone’s picture

bdone commented
Assigned: Unassigned » bdone

going to try some work on this one...

bdone’s picture

bdone commented

@marvil07: not sure this answers your question, but after completing the tasks in this issue, it looks like the source_provider annotation still uses checkRequirements(), only now from DrupalSqlBase::create().

bdone’s picture

bdone commented
Status: Active » Needs review
StatusFileSize
new imp-2202023-3.patch18.94 KB

attaching a first pass at this one...

chx’s picture

chx commented
Status: Needs review » Fixed

15 files changed, 42 insertions(+), 150 deletions(-)

That's how we like our patches! Thanks much, committed. (https://drupal.org/node/2208061 bot tested btw)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.