"See the parent issue, #2180187: [Meta] Refactor source ids, for an overview.
See #2180001: Add getIds to AggregatorFeed.php source and remove sourceIds from the migration: for a concrete example of what needs doing"

CommentFileSizeAuthor
#2 Refactor_source_id_in_File-2180477-2.patch660 bytesalvar0hurtad0

Comments

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
StatusFileSize
new Refactor_source_id_in_File-2180477-2.patch660 bytes
alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

Ups!! sorry I didn´t see it wass assigned.

:)

I'm soooo sorry friend Ryan.

Anonymous’s picture

Anonymous (not verified) commented

No worries!

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented

I ran FileSourceTest and had 1 failure.

Anonymous’s picture

Anonymous (not verified) commented

I'm retesting this, I think there was a problem with my testing setup.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Test failed with one exception:

FileSourceTest.php line 99
function Drupal\migrate_drupal\Tests\source\d6\FileSourceTest->testRetrieval()

Drupal\migrate_drupal\Tests\source\d6\FileSourceTest::testRetrieval Invalid argument supplied for foreach() /var/www/imp/core/modules/migrate/lib/Drupal/migrate/Plugin/migrate/source/SqlBase.php:92 /var/www/imp/core/modules/migrate/lib/Drupal/migrate/Plugin/migrate/source/SqlBase.php:188 /var/www/imp/core/modules/migrate/lib/Drupal/migrate/Source.php:222 /var/www/imp/core/modules/migrate/lib/Drupal/migrate/Source.php:265 /var/www/imp/core/modules/migrate/tests/Drupal/migrate/Tests/MigrateTestCase.php:85 /var/www/imp/core/modules/migrate/tests/Drupal/migrate/Tests/MigrateSqlSourceTestCase.php:100

Anonymous’s picture

Anonymous (not verified) commented

Retesting...

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Reviewed & tested by the community

Passes. Yessssssss

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.