Problem/Motivation

I found several rooms for improvement, such as:
1) Use hook_library() to load Swipebox library efficiently.
2) Load library when and where it's necessary only.
3) Use Drupal behaviors for integration javascript.
4) Add jquery_update dependency, as mentioned in #2067889: Any updates
5) Some cosmetic code improvements.

Proposed resolution

Provided a patch.

CommentFileSizeAuthor
#8 Bildschirmfoto 2014-07-01 um 23.10.31.png20.86 KBdaniel wentsch
swipebox-multiple-improvements-1953290-0.patch3.63 KBKonstantin Komelin

Comments

Konstantin Komelin’s picture

Konstantin Komelin commented
Status: Active » Needs review

Please review attached patch.

Since the module is working fine for me, even though it has some remaining tasks, such as passing settings to the JS script, I recommend displaying DEV release on the project page and promote this sandbox project to a full one.

  • Commit ebe9daf on 7.x-1.x by Daniel Wentsch: 
    several improvements by konstantin.komelin, issue #2289767
daniel wentsch’s picture

daniel wentsch commented
Status: Needs review » Fixed

Thanks for the patch. I just commited it and changed the default branch to 7.x-1.x.
How do I display a Dev release on the project page?
I've not been using this code in quite a while, would you like to become a maintainer?

Konstantin Komelin’s picture

Konstantin Komelin commented

Hi Daniel,

Thanks for reviewing and committing my patch.
Although next time please set proper Git attribution to give credits to the contributor https://www.drupal.org/node/1146430

How do I display a Dev release on the project page?

Firstly, you need to promote your sandbox project to Full https://www.drupal.org/node/1068952
Then you will be able to create releases for the project.
If you don't have permissions for creating Full projects I can create a release myself, just give me project and release management permissions.

I've not been using this code in quite a while, would you like to become a maintainer?

Thank you for the suggestion!
I don't mind of becoming a co-maintainer and helping with pushing this module to the stable stage. However, I can't spend too much time to implement new features.

Thanks,
Konstantin

Konstantin Komelin’s picture

Konstantin Komelin commented
Status: Fixed » Needs review

What did you decide? Release?

daniel wentsch’s picture

daniel wentsch commented

Sorry, I'm really too busy the next days and weeks to put a lot of effort in this.
I added you as a maintainer, feel free to apply for a release (I never did this, so I'd have to read into what to do exactly and how etc.)

I'll be more or less offline until next Monday.

Konstantin Komelin’s picture

Konstantin Komelin commented
Status: Needs review » Fixed

Hi Daniel,

Thanks, but I still don't have enough permissions to promote this project to full and create releases.

-- Konstantin

daniel wentsch’s picture

daniel wentsch commented
StatusFileSize
new Bildschirmfoto 2014-07-01 um 23.10.31.png20.86 KB

Hi Konstantin,

now you have all privileges I'm aware of, does this change anything?

Cheers,
Daniel

Konstantin Komelin’s picture

Konstantin Komelin commented

Hi Daniel,

Unfortunately, I can't promote the project to full because I don't see the Promote sub-tab https://www.drupal.org/node/1068952 . I don't know why. I remember that I promoted third-party modules earlier.

Maybe it's better if you apply for permissions here https://www.drupal.org/node/1011698

Best,
Konstantin

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.