Coming from Clean up the CSS for System module

Part of the CSS Cleanup: #1968914: [META] Sprint CSS cleanup

Overview of Goals

Make it easy to remove unwanted design assumptions in the theme layer, while maintaining critical functionality (such as functional JavaScript widgets).
Prevent unneeded administrative styles from loading on the front end.
Make CSS and related markup more efficient and less intrusive to improve the themer experience.

CommentFileSizeAuthor
#3 system-module-css-cleanup-2030627-3.patch14.3 KBm0d
#1 system-module-css-cleanup-2030627-2.patch14.28 KBm0d

Comments

m0d’s picture

m0d
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new system-module-css-cleanup-2030627-2.patch14.28 KB

Here the patch rerolled from #1969124: Clean up the CSS for System module

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Needs work

Maybe the following selectors should be less specific:

.system-modules div.incompatible
.system-modules th.checkbox
.system-modules th.name
.system-modules th.description

Following the coding standards, inline statements are not allowed:

.diff-deleted { color:#ccc; }
.diff-deleted img { border: solid 2px #ccc; }
.diff-changed { background:#ffb; }
.diff-changed img { border:solid 2px #ffb; }
.diff-added { background:#cfc; }
.diff-added img { border: solid 2px #cfc; }
m0d’s picture

m0d
Primary language English
Location UK
commented
StatusFileSize
new system-module-css-cleanup-2030627-3.patch14.3 KB

Ok! Changes applied, new patch attached.

m0d’s picture

m0d
Primary language English
Location UK
commented
Status: Needs work » Needs review

Changing state.

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Reviewed & tested by the community

Commited to 2030627-system-css-cleanup branch.

rteijeiro’s picture

rteijeiro commented
Status: Reviewed & tested by the community » Fixed

Merged into 8.x-css branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Adding reference issue.