I went through the UI and saw several problems:
1) The "Use addressbook" checkbox has no help text, which is a bit confusing.
2) The edit and delete profile user pages have no breadcrumbs.
3) The user pages have badly set titles:
'title' => ucfirst($type) . ' Profiles',
This is hard to translate (a placeholder should be used for the type name). And if the type name has an underscore, it won't be converted. Generally, we are inventing our own label based on the type machine name, which isn't pretty.
4) We have inconsistent language, showing on checkout "Addresses on File", but then in the user pages (under the "addressbook" url) we talk about "profiles", not addresses. I'm thinking about hiding the "profile" terminology from users and just going with "address". Thoughts?
5) The delete profile page doesn't use confirm_form(). A nice trick would be to use entity_view() to show the information being deleted. Commerce only does this for products, but it would be a great solution here.
There's also the question of keeping the "Summary" page, which doesn't have much utility right now.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1436956-addressbook-ui.patch | 5.4 KB | bojanz |
| #1 | before1.png | 60.06 KB | bojanz |
| #1 | before2.png | 39.72 KB | bojanz |
| #1 | before3.png | 20.14 KB | bojanz |
| #1 | after1.png | 71.69 KB | bojanz |
Comments
Comment #1
bojanz commentedHere's a proposal that addresses the five points I mentioned.
Not sure about the "address" terminology because the profile can have a phone number field (for example), and that is shown separately on the add / edit form (outside the "address" fieldset). Still, at least it's consistent.
Posting as a patch instead of committing because I want us to agree on the final UI look before merging this code upstream.
Comment #2
78doog commentedI think the UI changes are very good and the use of english much clearer for customers. My only suggestion is that the phrase "Deleting this address cannot be undone" is a little daunting to users and they can re-add any address later if they like. I think "remove" is better than "delete" in general. I would change the button to "Remove Address" and also say underneath "You can always add it again later." Colloquial and encouraging...... hopefully. I'm sure someone will have a better idea though.
Comment #3
liupascal commentedThese changes looks good to me - we definitely need a more "generic" approach and keep away any technical terms.
As for #2 comment, I think this is the core behavior to have this text, but I agree on your idea.
Comment #4
bojanz commentedCommitted.