--------------------------------------------------------------------------------------------------
This issue was created for the purpose of completing a Drupal Ladder lesson. The real issue was to protect the variable classes and had been solved and can be found on : https://www.drupal.org/node/2384531
--------------------------------------------------------------------------------------------------
RDFMapping class variables should not be accessed directly. Functions should be use to access the variable. For instance use getDescription() and setDescription($description) for the protected class variable description. For a boolean variable the getter function becomes isVariableName(). In object-oriented programming this is called encapsulation.
Remaining tasks
- Update the class variables and make them protected.
- Create getters and setters for frequently used get and set functionality.
- Update drupal to use the getters and setters instead of accessing variables directly.
- There are no tests required because the added functions are only getters and setters.
For more info over what should be done see the issue summary of #2016679: Expand Entity Type interfaces to provide methods, protect the properties.
Beta phase evaluation
| Issue category | Bug because properties should not be public, API methods should not be allowed to be sidestepped. |
|---|---|
| Issue priority | Major because this meta goes across the entire system. But each child will be a normal bug. |
| Prioritized changes | Prioritized since it is a bug and it reduces fragility. |
| Disruption | Somewhat disruptive for core as well as contributed and custom modules:
|
But impact will be greater than the disruption, so it is allowed in the beta.
Comments
Comment #1
tadityar commentedtest
Comment #2
tadityar commentedComment #3
avpaderno