ESI module has a Time To Live setting on the module settings page and a Lifetime setting on the Panels panel settings page.

1. These should probably be named the same thing.

2. Should there also be a zero value available for TTL? It seems like in some cases I want live data.

Thanks.

Comments

mikeytown2’s picture

mikeytown2 commented

"Not Cached" in the other thread #1334910: Add in the ability to set the scope of how the ESI bit of content will be cached. is where zero comes into mind. I'll normalize the naming, thanks for pointing it out. Would a zero for the TTL be better? Have both?

mikeytown2’s picture

mikeytown2 commented

Going to go for "maximum age". In pressflow drupal_page_cache_header_external() uses the variable (page_cache_max_age) set in system_performance_settings(); this is what pressflow uses to describe the time set in the cache control header under max-age=; ESI uses the same headers.

brianmercer’s picture

brianmercer commented

Consistency with the performance page sounds good.

The performance page settings allow a zero value for max age which it calls "none". I know that nginx will honor a "Cache-Control: max-age=0" without the addition of "no-cache", so that would work.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Fixed

This has been fixed in #1334910: Add in the ability to set the scope of how the ESI bit of content will be cached.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.