Closed (fixed)
Project:
WSCCI
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 May 2012 at 15:40 UTC
Updated:
24 May 2012 at 01:40 UTC
How in the world did we break the database? I mean really. Somehow we broke insert (DatabaseInsertTestCase), merge (DatabaseMergeTestCase), select (DatabaseSelectComplexTestCase), and transaction (DatabaseTransactionTestCase) tests. Probably a side-effect of me changing the exception handling a while back to always wrap a PDOException. Merge probably broke because of insert, because it wraps insert, so probably fixing insert will fix merge.
Someone please fix this.
Comments
Comment #0.0
Crell commentedMention broken merge tests, too.
Comment #1
pounardWhooooot fixed in the 1567438-database-transaction branch!
Comment #2
Niklas Fiekas commentedYay, thanks a lot!
I confirmed that the test failures are resolved.
Branch link: 1567438-database-transaction
Commit: 60ebceebf9607a63c
Diff for quick review:
Comment #3
Crell commentedMerged. Thanks!
Comment #4.0
(not verified) commentedAnd we broke select, too!