Would you mind releasing a 6.x version to make life easier on drush_make users?

Files: 
CommentFileSizeAuthor
#19 grammar_parser-1.2.info.patch450 bytessolotandem
#19 grammar_parser-1.2_file.make_.txt553 bytessolotandem
#19 grammar_parser-1.2_git.make_.txt570 bytessolotandem
#16 994518-7.2-to-d6.patch267 bytesrickvug
#15 grammar_parser_file.make_.txt549 bytessolotandem
#15 grammar_parser_git.make_.txt567 bytessolotandem
#13 994518.patch568 bytesSteven Jones
#6 grammar_parser.info.patch489 bytessolotandem
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch grammar_parser.info.patch.
[ View ]
#1 994518.patch541 bytesergonlogic
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

ergonlogic’s picture

Status:Active» Needs review
StatusFileSize
new541 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Drush Make should support this anyway, though you kind of have to twist it's arm. Try something like:

projects[grammar_parser][type] = module
projects[grammar_parser][download][type] = cvs
projects[grammar_parser][download][module] = contributions/modules/grammar_parser
projects[grammar_parser][download][revision] = DRUPAL-7--1-1
projects[grammar_parser][patch][994518][url] = "http://drupal.org/files/issues/994518.patch"
projects[grammar_parser][patch][994518][md5] = "eecc6f6aa76d0cc399fb4bf8300edcec"

Though this may be overkill. This should also work:

projects[grammar_parser][type] = module
projects[grammar_parser][download][url] = http://ftp.drupal.org/files/projects/grammar_parser-7.x-1.1.tar.gz
projects[grammar_parser][patch][] = "http://drupal.org/files/issues/994518.patch"
dmitrig01’s picture

yay knowing how to use drush make! :D

dmitrig01’s picture

in the second one, you need to specify

projects[grammar_parser][download][type] = get
solotandem’s picture

Status:Needs review» Fixed

Thanks for the tip, ergonlogic and dmitrig01. This seems to be an easy solution.

fgm’s picture

Status:Fixed» Active

Actually, the patch does not apply on the second version: in the 1.1 release, project packaging has added a "core = "7.x" " line, and patch apparently chokes upon the duplicate core line.

But it works with the first version (CVS) which does not containt the project packaging info.

solotandem’s picture

StatusFileSize
new489 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch grammar_parser.info.patch.
[ View ]

How about this patch for use with the second version?

ergonlogic’s picture

Status:Active» Needs review

Setting to "needs review" so the testing bot finds the latest patch :)

For those of you playing along at home, the non-CVS makefile should now read:

projects[grammar_parser][type] = module
projects[grammar_parser][download][type] = get
projects[grammar_parser][download][url] = http://ftp.drupal.org/files/projects/grammar_parser-7.x-1.1.tar.gz
projects[grammar_parser][patch][] = "http://drupal.org/files/issues/grammar_parser.info.patch"

Status:Needs review» Needs work

The last submitted patch, grammar_parser.info.patch, failed testing.

solotandem’s picture

Status:Needs work» Fixed

I purposely did not set to "Needs review" as the patch was guaranteed to not apply as it is intended for the packaged version of code not the CVS version. Marking fixed until someone reports it does not work with drush make. Thanks for all the input on this.

dmitrig01’s picture

is there a handbook page or somehwere this can be documented?

solotandem’s picture

Added a sentence on the project page with a link to this issue.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Steven Jones’s picture

StatusFileSize
new568 bytes

Note that the dev release (at least) seems to require the autoload module, so this should be added to the info file as well.

solotandem’s picture

This module does not need the autoload module to function properly. Rather, adding the autoload module as a dependency would apply to modules that want to use this module along with the PHP lazy loading support offered by the autoload module, instead of including load statements in their code.

Please file an issue with the other modules.

Also, I had submitted a patch to Libraries module to backport its 7.x-.2x branch to a new 6.x-2.x branch. This would also allow for auto loading the code files. This patch has not been committed to Libraries. For D7, the Libraries module is suggested for use with this module.

solotandem’s picture

StatusFileSize
new567 bytes
new549 bytes

Attached are two updated Drush make files for use with the 7.x-1.1 release -- git repository and file download. Please remove the ".txt" extension before using.

The "git repository" version can easily be changed to grab the master == 7.x-1.x branch by deleting (or commenting) the line:

projects[grammar_parser][download][tag] = 7.x-1.1

The "file download" version will require a new patch file along with changing the version number in the line:

projects[grammar_parser][download][url] = http://ftp.drupal.org/files/projects/grammar_parser-7.x-1.1.tar.gz
rickvug’s picture

StatusFileSize
new267 bytes

Attaching a patch for the 7.2 release of Grammar Parser.

rickvug’s picture

Title:6.x release to support drush_make?» 6.x release to support drupal.org's packaging system
Status:Closed (fixed)» Needs review

I'm reopening this issue as the present solution doesn't work with Drupal.org's distribution packaging system. I asked to get the present workaround approved as a whitelisted path but that idea was rejected. See #1470692: Add Grammar Parser to white list (or provide an alternative solution) for the conversation. I know it is a bit of a hassle to maintain two branches but it is the only workable solution that I see to solve the packaging problem.

What does everyone think? It would be great to fix the problem, one way or another.

solotandem’s picture

Is the drush make solution in #15 not possible for you?

solotandem’s picture

Title:6.x release to support drupal.org's packaging system» Use in a Drupal 6.x environment
Assigned:Unassigned» solotandem
Status:Needs review» Fixed
StatusFileSize
new570 bytes
new553 bytes
new450 bytes

As stated elsewhere, the Grammar Parser is a library independent of Drupal versions. The fact that it is hosted on d.o. with releases created by a packaging system that is not intended for a library is another topic. As with any library, a project that relies on it (in a 6.x environment or newer) should NOT include it as a dependency in the info file, but rather include instructions on how to download it. One good choice is to include a drush make file along the lines of one of the attached make files.

Errata: the attached file version of the make file includes the path to the patch as "http://drupal.org/files/issues/" instead of "http://drupal.org/files/." Please edit accordingly.

solotandem’s picture

rickvug’s picture

@solotandem Thank you for the new examples. With a small modification to remove the MD5 check I was able to get Grammar Parser to pass Drupal.org packaging verification. However the build still failed, for reasons that I unknown to me at the moment. If you want to have a look see http://drupal.org/node/1470692#comment-5757930. Thank you for the help in clarifying this issue.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.