Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Would you mind releasing a 6.x version to make life easier on drush_make users?
Comment | File | Size | Author |
---|---|---|---|
#19 | grammar_parser-1.2.info.patch | 450 bytes | solotandem |
#19 | grammar_parser-1.2_file.make_.txt | 553 bytes | solotandem |
#19 | grammar_parser-1.2_git.make_.txt | 570 bytes | solotandem |
#16 | 994518-7.2-to-d6.patch | 267 bytes | rickvug |
#15 | grammar_parser_file.make_.txt | 549 bytes | solotandem |
Comments
Comment #1
ergonlogicDrush Make should support this anyway, though you kind of have to twist it's arm. Try something like:
Though this may be overkill. This should also work:
Comment #2
dmitrig01 CreditAttribution: dmitrig01 commentedyay knowing how to use drush make! :D
Comment #3
dmitrig01 CreditAttribution: dmitrig01 commentedin the second one, you need to specify
Comment #4
solotandem CreditAttribution: solotandem commentedThanks for the tip, ergonlogic and dmitrig01. This seems to be an easy solution.
Comment #5
fgmActually, the patch does not apply on the second version: in the 1.1 release, project packaging has added a "core = "7.x" " line, and patch apparently chokes upon the duplicate core line.
But it works with the first version (CVS) which does not containt the project packaging info.
Comment #6
solotandem CreditAttribution: solotandem commentedHow about this patch for use with the second version?
Comment #7
ergonlogicSetting to "needs review" so the testing bot finds the latest patch :)
For those of you playing along at home, the non-CVS makefile should now read:
Comment #9
solotandem CreditAttribution: solotandem commentedI purposely did not set to "Needs review" as the patch was guaranteed to not apply as it is intended for the packaged version of code not the CVS version. Marking fixed until someone reports it does not work with drush make. Thanks for all the input on this.
Comment #10
dmitrig01 CreditAttribution: dmitrig01 commentedis there a handbook page or somehwere this can be documented?
Comment #11
solotandem CreditAttribution: solotandem commentedAdded a sentence on the project page with a link to this issue.
Comment #13
Steven Jones CreditAttribution: Steven Jones commentedNote that the dev release (at least) seems to require the autoload module, so this should be added to the info file as well.
Comment #14
solotandem CreditAttribution: solotandem commentedThis module does not need the autoload module to function properly. Rather, adding the autoload module as a dependency would apply to modules that want to use this module along with the PHP lazy loading support offered by the autoload module, instead of including load statements in their code.
Please file an issue with the other modules.
Also, I had submitted a patch to Libraries module to backport its 7.x-.2x branch to a new 6.x-2.x branch. This would also allow for auto loading the code files. This patch has not been committed to Libraries. For D7, the Libraries module is suggested for use with this module.
Comment #15
solotandem CreditAttribution: solotandem commentedAttached are two updated Drush make files for use with the 7.x-1.1 release -- git repository and file download. Please remove the ".txt" extension before using.
The "git repository" version can easily be changed to grab the master == 7.x-1.x branch by deleting (or commenting) the line:
The "file download" version will require a new patch file along with changing the version number in the line:
Comment #16
rickvug CreditAttribution: rickvug commentedAttaching a patch for the 7.2 release of Grammar Parser.
Comment #17
rickvug CreditAttribution: rickvug commentedI'm reopening this issue as the present solution doesn't work with Drupal.org's distribution packaging system. I asked to get the present workaround approved as a whitelisted path but that idea was rejected. See #1470692: Add Grammar Parser to white list (or provide an alternative solution) for the conversation. I know it is a bit of a hassle to maintain two branches but it is the only workable solution that I see to solve the packaging problem.
What does everyone think? It would be great to fix the problem, one way or another.
Comment #18
solotandem CreditAttribution: solotandem commentedIs the drush make solution in #15 not possible for you?
Comment #19
solotandem CreditAttribution: solotandem commentedAs stated elsewhere, the Grammar Parser is a library independent of Drupal versions. The fact that it is hosted on d.o. with releases created by a packaging system that is not intended for a library is another topic. As with any library, a project that relies on it (in a 6.x environment or newer) should NOT include it as a dependency in the info file, but rather include instructions on how to download it. One good choice is to include a drush make file along the lines of one of the attached make files.
Errata: the attached file version of the make file includes the path to the patch as "http://drupal.org/files/issues/" instead of "http://drupal.org/files/." Please edit accordingly.
Comment #20
solotandem CreditAttribution: solotandem commentedSee #1491330: Replace grammar parser dependency with a make file .
Comment #21
rickvug CreditAttribution: rickvug commented@solotandem Thank you for the new examples. With a small modification to remove the MD5 check I was able to get Grammar Parser to pass Drupal.org packaging verification. However the build still failed, for reasons that I unknown to me at the moment. If you want to have a look see http://drupal.org/node/1470692#comment-5757930. Thank you for the help in clarifying this issue.