Trying to attach existing nodes returns Page not found

facing the same problem, even cleared cache, run cron, rebuild permission...

Facing the same problem too.
any solution?

Something is indeed wrong.

Here's a quick fix to the issue, that at least gets the page loaded. Not really sure what that load function actually do, so if someone can shed some light here that would be nice.

I'm having the same problem, and it would really be a nice feature. Has anyone tried the patch above?

TC

I have the patch running without issues, but we need a maintainer or someone with better knowledge of the module to review the changes.

The patch did not work for me. I was able to workaround this problem by just adding new relationships directly into the relativity mysql table. It is fairly straight forward... nid and parent_nid. I inserted the appropriate nids and the relationship showed up on the site. The "Attach existing Page" link is still dead, but at least the page hierarchy is in there.

Same problem here - patch did not work for me.

Sorry I'm unable to reproduce this bug report. The diff between 1.3 and 1.4 in this area is:

     $items['relativity/listnodes/%relativity_node_list/parent/%node'] = array(
       'title' => 'list of !type nodes to attach',
-      'title arguments' => array('!type' => node_get_types('name', arg(2))),
+      'title arguments' => array('!type' => node_get_types('name', 2)),
       'load arguments' => array(4),
       'page callback' => 'relativity_list_possible_children',
       'page arguments' => array(2, 4),
-      'access callback' => 'relativity_access_listnodes',
-      'access arguments' => array('update', 4, 'add child relations'),
+      'access arguments' => array('add child relations'),
       'type' => MENU_CALLBACK,
     );
 

Drupal should catch this change upon a menu rebuild. You can trigger a menu rebuild by submitting the admin/build/modules form.

Can anyone reproduce this bug with a fresh install of drupal+relativity?

I tried changing the following lines and it loads the page successfully.

<?php
-    $items['relativity/listnodes/%relativity_node_list/parent/%node'] = array(
+    $items['relativity/listnodes/%relativity_node_list/parent/%'] = array(

...

-    $items['relativity/addparent/%node/parent/%node'] = array(
+    $items['relativity/addparent/%/parent/%'] = array(

...
?>

I've also updated the following function:

<?php
function relativity_list_possible_children($type, $parent) {
  $links = array();
+   $parent = node_load($parent);
  $relativity_query = variable_get('relativity_child_query_'. $parent->type .'_'. $type, NULL);
  $common_children_reqd = variable_get('relativity_common_child_'. $parent->type .'_'. $type, array());

...
}
?>

Hope it helps.

yosepkur , comment #10 is right.

Keep %node in 'relativity/addparent/%node/parent/%node'
but rework function relativity_addparent($child_nid = "", $parent_nid = "") {...} to accept two nodes instead:
relativity_addparent($child_node, $parent_node) {...}
No need to rely on arg().

yosepkur is right for 'relativity/listnodes/%relativity_node_list/parent/%node'.
There is a conflict with the node loader called with %node and the 'load arguments' => array(4).
The relativity_node_list_load() already checks that the nid is valid.

The code is a bit ugly though. It is trying to be too clever with the menu API but it's not using the wildcards exactly the way it was intended.
The badly named relativity_node_list_load() should not check whether the node->nid exist. It's done for us by node_load() thanks to the wildcard %node.
Instead relativity_node_list_load() should simply check that the node type is within relativity_node_list() and return either FALSE if not, or the machine node type.
Then both the node type and the fully loaded node can be passed to relativity_list_possible_children().

passing '2' to node_get_types within hook_menu does not work either:
'title arguments' => array('!type' => node_get_types('name', 2))
The patch in #4 is pointing at this problem but it's merely offering a hack, breaking the original intend.

I don't think that we can use 'title arguments' the way it's used here. Remove it completly and use drupal_set_title() manually in the callback function.