This happened several times to me, and it is a major problem.
Sometimes editing a newsletter issue again makes the "Send newsletter" radio being selected by default, and obviously when saving, the newsletter is sent without wanting to.
And there is no way to cancel the sending afterwards.

CommentFileSizeAuthor
#13 simplenews.js_.patch591 bytesanrikun
#10 simplenews.js_.patch429 bytesanrikun
#9 simplenews.js_.patch429 bytesanrikun

Comments

anrikun’s picture

anrikun commented

I have just noticed that this happens when refreshing the node edit page!
Every time you refresh the page, the selected radio button moves down:
if it was "Do not send", it becomes "Send a test"
if it was "Send a test", it becomes "Send",
if it was "Send", it becomes "Do not send" again
Really strange isn't it?

simon georges’s picture

simon georges commented

Sure, it's strange, and thank you for pointing out such details. I'll take a look at it tomorrow.

anrikun’s picture

anrikun commented

This might be some kind of conflict with another module as I cannot reproduce it on a fresh install.
I'll do more research.

anrikun’s picture

anrikun commented
Priority: Critical » Normal

Let's change this "normal" while doing researches.

simon georges’s picture

simon georges commented

I cannot reproduce the bug you're describing (neither in 6.x-1.3, nor in 6.x-1.x-dev). I suppose you have another module enabled with a hook_form_alter() interfering.

anrikun’s picture

anrikun commented

Yes you must be right. I'll try to find what module is causing the problem and let you know.

anrikun’s picture

anrikun commented

The module that is causing the problem seems to be CKEditor!
I need to understand why now.

anrikun’s picture

anrikun commented
Title: When editing a newsletter issue again, sometimes "Send newsletter" gets checked by default » When used with CKEditor and Firefox, "Send action" radio buttons change on page refresh

It seems that it is a bug of Firefox:
http://www.ryancramer.com/journal/entries/radio_buttons_firefox
But why does it happen only when using CKEditor?

anrikun’s picture

anrikun commented
StatusFileSize
new simplenews.js_.patch429 bytes

Here is a patch for 1.3 and 1.x-dev that seems to fix this issue.
I know that this issue is not a bug of Simplenews but I think this patch should be committed as it won't hurt.

anrikun’s picture

anrikun commented
Status: Active » Needs review
StatusFileSize
new simplenews.js_.patch429 bytes

The same patch for 2.x-dev.

Both seem the same actually :-D

anrikun’s picture

anrikun commented
Version: 6.x-1.3 » 6.x-2.x-dev
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Please add comments why this is needed in the code.

Thx.

anrikun’s picture

anrikun commented
StatusFileSize
new simplenews.js_.patch591 bytes

Here you are :-)

This patch will not be needed if #988412: Require confirmation before sending the newsletter is implemented instead.

simon georges’s picture

simon georges commented

The patch would not be needed either if #781708: Move simplenews node actions into Tab is completed, as I removed the javascript entirely.

anrikun’s picture

anrikun commented

Great, I will test it, this is a nice feature!

simon georges’s picture

simon georges commented

#781708: Move simplenews node actions into Tab has been committed, I'm just wondering if we should close this one or still commit the fix on 6.x-1.x. Miro, what do you think ? (I'm willing to do it if you think it's appropriate. Are you planning a final 6.x-1.x release with the current fixes for those who don't want to upgrade ?)

simon georges’s picture

simon georges commented
Version: 6.x-2.x-dev » 6.x-1.x-dev

Changing the version to make the issue queue cleaner.

simon georges’s picture

simon georges commented
Status: Needs review » Fixed

Committed to 6.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.