Use DrupalUnitTestCase where possible

Looks awesome. This would have to go into 8.x first. Needs a reroll.

rerolled for 8.x, picked up from novice queue

+++ b/core/modules/simpletest/tests/common.test
@@ -73,7 +73,7 @@ class CommonDrupalAlterTestCase extends DrupalWebTestCase {
  * url() calls module_implements(), which may issue a db query, which requires
  * inheriting from a web test case rather than a unit test case.
  */
-class CommonURLUnitTestCase extends DrupalWebTestCase {
+class CommonURLUnitTestCase extends DrupalUnitTestCase {

The comment right above the class definition explains why it's not a unit test.

+++ b/core/modules/simpletest/tests/theme.test
@@ -118,7 +118,7 @@ class ThemeUnitTest extends DrupalWebTestCase {
  * Unit tests for theme_table().
  */
-class ThemeTableUnitTest extends DrupalWebTestCase {
+class ThemeTableUnitTest extends DrupalUnitTestCase {

Theme function tests are functional tests and not unit tests by design, as they rely on the theme registry, and we don't want to test the theme registry or behavior of the parent site that is executing the test.

okay, reverting those two back.

#9: improve_test_performance-984874-5482608.patch queued for re-testing.

I think this could be committed.

+++ b/core/modules/simpletest/tests/common.test
@@ -524,7 +524,7 @@ class CommonSizeUnitTestCase extends DrupalUnitTestCase {
-class CommonAutocompleteTagsTestCase extends DrupalWebTestCase {
+class CommonAutocompleteTagsTestCase extends DrupalUnitTestCase {

@@ -2171,7 +2171,7 @@ class CommonSimpleTestErrorCollectorTestCase extends DrupalWebTestCase {
-class CommonDrupalParseInfoFileTestCase extends DrupalWebTestCase {
+class CommonDrupalParseInfoFileTestCase extends DrupalUnitTestCase {

+++ b/core/modules/simpletest/tests/unicode.test
@@ -8,7 +8,7 @@
-class UnicodeUnitTest extends DrupalWebTestCase {
+class UnicodeUnitTest extends DrupalUnitTestCase {

OK

+++ b/core/modules/simpletest/tests/common.test
@@ -1035,7 +1035,7 @@ class CommonDrupalHTTPRequestTestCase extends DrupalWebTestCase {
-class CommonRegionContentTestCase extends DrupalWebTestCase {
+class CommonRegionContentTestCase extends DrupalUnitTestCase {

Not OK. Calls into system_region_list(), and relies on the global $theme_key.

+++ b/core/modules/simpletest/tests/image.test
@@ -194,7 +194,7 @@ class ImageToolkitUnitTest extends ImageToolkitTestCase {
-class ImageToolkitGdTestCase extends DrupalWebTestCase {
+class ImageToolkitGdTestCase extends DrupalUnitTestCase {

Not OK. Calls into image_get_available_toolkits(), which invokes module hooks to return available image toolkits, which in turn means that it relies on the system environment/configuration.

+++ b/core/modules/simpletest/tests/xmlrpc.test
@@ -3,7 +3,7 @@
-class XMLRPCBasicTestCase extends DrupalWebTestCase {
+class XMLRPCBasicTestCase extends DrupalUnitTestCase {

Not OK. Performs a HTTP request to core/xmlrpc.php, which in turn invokes hook_xmlrpc() in all modules, and thus, relies on the system environment/configuration.

@sun when you mean 'Not OK' are you advising removal of that line? If so I can cut out those last 3 and re-roll.

Yes - the changes than @sun marked as Not OK need to be removed from the patch.

Cool, re-rolled!

Thank you.

Those tests are - like sun already stated - not dependent on configuration and environment, so yeah, that seams to be it. Though fewer conversions are left than I hoped for ;)

Good catch. Committed to 8.x.

Moving to 7.x for back-porting.

D7 backport.

Thank you.

Shortening and clarifying issue, since every time I see this issue I'm thinking of something completely different.

Committed and pushed to 7.x. Thanks!