I've added a few related enhancements into the modr8 module.

1) In addition to "no action", "delete" and "approve" I have added a "resubmit" option. Resubmit sends your note back to the contributor and leaves the node in moderation. I did something with the workflow here that needs a second check. When a node is sent for resubmission I set the node.moderate field to a value of 2. Everything in core checks =0 or !=0, so this works. I've checked a lot of modules (but not all) and they too compare against a value of 0 rather than 1. This new value has the following effect: When an entry is rejected it remains in moderation as far as Drupal core and most (possibly all) modules are concerned. To modr8 the node.moderate value of 2 means not to show it in the moderation page. When the user edits and saves the node Drupal sets the moderate flag back to 1 and the cycle begins again. I think this use of the moderate value is safe. I'd appreciate an opinion from somebody deeper into core than I am.

2) Added the ability to configure which options are shown to the site moderators. Checkboxes have been added to the modr8 settings page that control whether each of the four (no action, approve, delete, resubmit) options appear to moderators.

3) Added an optional email address to which a copy of moderated messages will be sent. Presumably this would be to a mailing list of site moderators to keep them aware of new submissions to the site.

CommentFileSizeAuthor
moderate_resubmit_feature.patch9.23 KBscott.mclewin

Comments

pwolanin’s picture

pwolanin commented

These are interesting proposals, but there are too many unrelated things in this one patch- can you split it into ~3 independent patches with separate issues? That will make it easier to test and review.

Note also, in the 5.x update I added a block that lists nodes in moderation, which might (or might not) satisfy your idea about keeping moderators up to date on what's in the queue. Another possibility would be a once-daily e-mail with a list of links to nodes in moderation.

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Needs work
scott.mclewin’s picture

scott.mclewin commented

I'll break it up into two, the notification (#3) and the first two, which intersect. I'd have to make a second patch that assumed the first one was applied in order to break them up.

On #3 this is not to notify of items in queue, but to notify of items that have been cleared through the moderation queue. If I've understood the block, I don't think it answers that need.

pwolanin’s picture

pwolanin commented

From reading #3, I thought you proposed to e-mail when new items are added to the queue (I assumed so that the moderators could go and read it). What's the benefit of notifying moderators if content is approved out of the queue?

scott.mclewin’s picture

scott.mclewin commented

I am sure it is not for everybody. For the site we run [1] the moderators review eachothers work. We also want to keep up with the comments that are sent back on moderation (the note field in modr8) to make sure that one of us can pick up a support context with a contributing user on our site when the approving moderator is unavailable.

Scott

[1] www.folkjam.org

moshe weitzman’s picture

moshe weitzman commented

@Scott - seems like you are better off with a moderation log as per http://drupal.org/node/80437

scott.mclewin’s picture

scott.mclewin commented

@Moshe - That too would be fine. I'll move some of the follow-on questions I have into the issue you referenced. My challenge right now is that I have a six day old child on my hands and no time to roll new patches, much less get enough sleep. :) For at least the near term this patch stands as it is.

pwolanin’s picture

pwolanin commented
Status: Needs work » Closed (fixed)
scott.mclewin’s picture

scott.mclewin commented

Peter - the new features in the v5 version of modr8 where an audit trail is created is great. Thanks, that covers the moderation group email feature.

The resubmit option as you implemented it in v5 is good with the message on no-action (and much better in that it does not use a bastard value in the node.moderate field as mine did).

Just noting this here on the off chance you ever look at closed out issues. :) I did make it back, but it took a while as the baby was more important.