Specify Image Dimensions

Good idea, but hardly a bug, more a feature request.

Anyway, this is the code that defines the image size (see function _image_captcha_generate_image in image_captcha.user.inc:

  $font_size = (int) variable_get('image_captcha_font_size', 30);
  $character_spacing = (float) variable_get('image_captcha_character_spacing', '1.2');
  $characters = _image_captcha_utf8_split($code);
  $character_quantity = count($characters);
  $width = $character_spacing * $font_size * $character_quantity;
  $height = 2 * $font_size;

  // create image resource
  $image = imagecreatetruecolor($width, $height);

For this issue, I would recommend to factor this code out in a function like image_captcha_image_size() and then use this function in _image_captcha_generate_image() and in image_captcha_captcha()

that's fast :)

I didn't try the patch yet (only read it), but here is just a tip to make the code cleaner:

function image_captcha_image_size() {
  //....
  return array($width, $height);
}

// ...
list($width, $height) = image_captcha_image_size();

Also, the patch seems to introduces tab instead of spaces for indentation in image_captcha.module.

thanks for the update.

some remarks
in image_captcha_image_size:
- $fonts = _image_captcha_get_enabled_fonts(); is not needed I think
- $code is used but not defined, there must be something wrong here.

in _image_captcha_generate_image: still using $arr['width'] instead of list(width, ...)

Hi elachlan,

I reworked your patch a bit: renamed to function "_image_captcha_image_size" (with leading underscore), moved it to image_captcha.module (from image_captcha.user.inc) and added a bit more documentation.

Committed: http://drupal.org/cvs?commit=456624

thanks for your work