Hi,

I have found bug(?) on node default page. It turns out, that on /node page there is no pager.
I looked in taxonomy page (function taxonomy_term_page) where $buld['pager'] look little diffrent then in node_page_default function.
When i replaced code in node module from taxonomy module pager is displayed.

CommentFileSizeAuthor
node-frontpage-pager.patch484 bytesquex

Comments

Status: Needs review » Needs work

The last submitted patch, node-frontpage-pager.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Actually '#theme' => 'pager', is correct. If taxonomy module still does '#markup' => theme('pager') that is a bug.
If the pager doesn't display at /node, that, of course, is also a bug.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

I just tested locally, with a ~2 day old HEAD, and I get a proper pager.

@quex: Could you provide more information about your setup?

Also: opened #978326: taxonomy_term_page uses pre-render-array theming

quex’s picture

quex commented

I upgraded drupal 6.19 with all content, to drupal-7.0-beta3. I use Bartik theme, and i use few modules like views, ctools and gravatar.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

So I am assuming that before the upgrade you had a pager and now you don't.

Could you please check two things:
1. Is your home page handled by Drupal core or is it a view handled by Views module?
2. Under Configuration >> System >> Site information what have you selected as "How many nodes should be displayed on the front page"?

quex’s picture

quex commented

My frony page is handled by Drupal core exacly function node_page_default(). I have 5 nodes per page.
When i replaced '#theme' => 'pager' to '#markup' => theme('pager'), then pager was visible.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Hmm. That's very strange.
1. I cannot reproduce that, as stated above
2. '#theme' => 'pager' to '#markup'= > theme('pager') should make no difference (except the latter being less alterable and therefore the former being preferable).
I'll try to look into this in the next days and see if I can find something.

Just for the fun of it, can you apply the patch in #978326: taxonomy_term_page uses pre-render-array theming (changes '#markup' => theme('pager') to '#theme' => 'pager' on taxonomy page) and see if you still get a pager on the taxonomy page?

quex’s picture

quex commented

Nope, unfortunately still that same. There is no pager on taxonomy/term pages, after apply patch.

joachim’s picture

joachim commented
Status: Needs work » Postponed (maintainer needs more info)

The page on the front page works fine for me.

quex’s picture

quex commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Problem does not exists when i install new drupal7-beta3 site (not upgraded from 6.19).

joachim’s picture

joachim commented
Status: Closed (won't fix) » Closed (cannot reproduce)

Thanks for reporting back.

Setting correct status.

kip stanning’s picture

kip stanning commented

i have the same bug on a d7-site. can't figure out where it's coming from. on a fresh d7-install i could not reproduce it. first i thought it might be caused by front-page module. i first disabled the checkbox for front-page override then turned off the module. none of these made the pager appear.

EDIT: problem seems to result from the presence of more than one pager on the same page with at least some of them having the same pager id. the pager id can be set if you choose to page the output of a view-display (mini or full, the other options of the pager-section in the views-admin-panel don't offer pager-id settings).
drupal-site-search for pager-id: http://drupal.org/search/apachesolr_multisitesearch/%22pager%20id%22