'title' => t('Add new comment'),
                'href' => "comment/reply/$node->nid",
                'attributes' => array('title' => t('Add a new comment to this page.')),
// ... meanwhile, in another part of the wood...
              'title' => t('Add new comment'),
              'attributes' => array('title' => t('Share your thoughts and opinions related to this posting.')),
CommentFileSizeAuthor
#13 977440-13.patch2.84 KBandypost
#8 977440-8.patch877 bytesandypost
#1 977440_add_comment_links_title_attributes.patch694 bytesamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 977440_add_comment_links_title_attributes.patch694 bytes

The second one sounds better to me, so here's a patch for that.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Issue tags: +String freeze

Adding "string freeze" tag.

joachim’s picture

joachim commented

It is technically string freeze? We're not adding or changing any strings, just removing one.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Priority: Normal » Minor

Hmmm, the "Share your thoughts and opinions related to this posting" sounds too deep and heavy to me. The first one, "Add a new comment to this page." is actually misleading since it's shown on the teaser (so "this page" is not the page where you'll be adding your comment).

joachim’s picture

joachim commented
Version: 7.x-dev » 8.x-dev
Issue tags: -String freeze
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

#1: 977440_add_comment_links_title_attributes.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 977440_add_comment_links_title_attributes.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: add comment links have mismatched title attributes » Clean-up comment links title attributes
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 977440-8.patch877 bytes

Re-roll, suppose we should find better title for the link for example replace "posting" with "content"

PS: There's also Jump to the first comment of this posting.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2377849: Simplify what CommentLinkBuilder is doing - consider removing a lot of the functionality

Related issue will clean-up some code

yoroy’s picture

yoroy commented

Simplest fix could be to just leave out the "referencing" bits:

"Add a new comment" and "Share your thoughts and opinions"

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

So, in my opinion, posting is a strange word to be using here. I like @yoroy's suggestion - especially "Add a new comment" since when someone comments that might not be sharing their thoughts and opinions but doing something else... To me that text is too opinionated. I agree that we should be consistent.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 977440-13.patch2.84 KB

So I cleaned all the strings by removing "posting" as @yoroy suggested

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a minor bug fix and strings are not yet frozen, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1cac4b5 and pushed to 8.0.x. Thanks!

  • alexpott committed 1cac4b5 on 8.0.x 
    Issue #977440 by andypost, amateescu: Clean-up comment links title...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.