mm_emfield: deleting files

Hi Arthur,
You mention:

I will say that the deletion handling is better in 6.2.x

When do you expect to have an alpha release of 6.2.x? I'm wondering if it might be better to wait, and make my code changes to the 6.2 version.

Hi again,
If I am understanding the code correctly, it looks like the function media_mover_api_node_update($node) invokes
media_mover_api_file_delete_call()
when a node attachment has been deleted, but not when a filefield has been deleted.

function media_mover_api_node_update($node) {
  // we only do this if there are media mover files that we need to delete
  // because they are linked to files on a node
  // we do not handle creation as other modules are responsible for that
  if ($node->media_mover) {
    // build a list of all the media mover files associated with this node
    foreach ($node->media_mover as $cid => $mm_files) {
      if ($mm_files) {
        foreach ($mm_files as $mm_file) {
          // load the configuration for this file
          $config = media_mover_api_get_configuration($mm_file['cid']);
          // check and see if this media mover file comes from a drupal file AND the
          // drupal file will be removed  AND the configuration removes files
            if ($node->files[$mm_file['fid']]->remove && $config->settings->mma_node_item_delete ) {
            media_mover_api_file_delete_call($mm_file);
          }
        }
      }
    }
    // now reset the nodes media mover cache
    cache_clear_all('media_mover_files_node_'. $node->nid, 'cache_media_mover');
  }
}

In particular, when a filefield has just been deleted:
(a) $node->media_mover is not set.
(b) $node->files[$mm_file['fid']]->remove is not set

I can see how to fix (a), by an explicit call to media_mover_api_node_files_fetch($node->nid)
But I am at a loss for how to address (b), i.e. how to tell in hook_nodeapi that a filefield has just been deleted. Any suggestions?

Never mind. I think I figured out how to handle deleted filefields, using hook_file_references.

I modified media_mover_api.module and mm_emfield.module, so that when a filefield is deleted, the corresponding emfield is deleted as well.

The changes are in the attached patch files, and were created using "diff". Will that work for you?

Also, if you would like an explanation of the changes, just let me know.

P.S. I submitted a feature request to media_youtube, to add a 'delete' clause to its media_mover hook.
See http://drupal.org/node/981058

A questions about moving the functionality from $op = 'update' to $op = 'presave' I'm not totally sure if this is the right thing to do. My main concern when I chose to do it with 'update' was the case when a module might get called after media mover- in this case media mover would never know when to delete the file- well maybe on a secondary save. Perhaps I'm wrong here, but that was my thinking anyway.

The reason for switching from 'update' to 'presave' is that I was not able to modify the node from within $op = 'update'. After struggling with this for a while, I went back to the hook_nodeapi documentation and found this:

# "presave": The node passed validation and is about to be saved. Modules may use this to make changes to the node before it is saved to the database.
# "update": The node has just been updated in the database.

So it seems node_save() is called before $op = "update".

Before switching to $op = "presave", I tried making an explicit call to node_save() from within $op = "update". But that caused an error: "node was modified by another user and could not be saved"

Do you have any suggestions for an alternate approach?

@zuriwest
I created a node type containing:
- multi-valued filefield
- multi-valued emvideo field

Then a created a media-mover configuration:
- harvest: harvest files from this filefield
- process: upload the harvested files to youtube
- complete: save result (link to youtube video) in an emfield

When cron runs, media-mover will harvest all of the as-yet-unharvested videos from this filefield, upload them to youtube, and then save the youtube links to the emfield.

Hi Arthur,
Just checking back to see how you would like to handle the proposed patch. (See my comment #9 above.)
Thanks

See here for a patch to media_mover_api_node_update() that does not require any changes to hook_nodeapi or mm_emfield.module: http://drupal.org/node/1478246

Here is a patch for what I believe is a different bug in mm_emfield. The function mm_emfield_node_file_delete() hard-codes the verb to 'complete', rather than looking up the verb in $configuration.

The patch replaces:
if ($url = $file['complete_file']) {
With:

$verb = $configuration['verb'];
if ($url = $file[$verb . '_file']) {

Forgot to change category to "bug report" in previous comment.