Improve links for steps after installing new theme [#975134]

Comment	File	Size	Author
#18	975134-17.install-theme.png	28.49 KB	dww
#18	975134-17.post-install-admin-appearance.png	98.88 KB	dww
#17	theme-wine-win.patch	992 bytes	rschwab
#14	theme-install-alt.patch	1.03 KB	rschwab
#11	updated-theme-links.patch	994 bytes	rschwab
#8	updated-theme-links.patch	1.11 KB	rschwab
#1	updated-theme-links.patch	1.02 KB	rschwab
	update-manager-install-theme-new.jpg	12.64 KB	rschwab
	update-manager-install-theme.jpg	11.57 KB	rschwab

Comment #1

rschwab commented 18 November 2010 at 08:05

Status:

Active

» Needs review

Status	File	Size
new	updated-theme-links.patch	1.02 KB

Patch to change the links as described above. The links now do what they say they do.

Log in or register to post comments

Comment #2

dww

we/he/they

commented 29 November 2010 at 04:07

Looks great to me, but I don't feel qualified to RTBC this given the scolding I got from Bojhan over at #602484-28: Fix the report page when authorize.php completes an update manager operation. ;) Hopefully the 'Usability' tag is enough to get his attention. If not, someone should try to ping him (or yoroy) in IRC and get one of their blessings.

Thanks rschwab!

Cheers,
-Derek

Log in or register to post comments

Comment #3

Bojhan commented 29 November 2010 at 15:06

I think this issue is near a won't fix. Why would going to settings be a common task? Additionaly going directly to enabling as the only option to me sounds rather drastic. So yhea, not sure.

Log in or register to post comments

Comment #4

rschwab commented 29 November 2010 at 17:13

Well clearly we don't want a link that says "Set the X theme as default" if:
A) That is an inherently wrong thing to do after installing a theme
and
B) The link doesn't do that anyways.

But anyways I disagree about those options. When I install a theme those are pretty much the two things I'd want to do next. Since we have less than a day to fix this, can you please suggest an alternative to the current setup?

Log in or register to post comments

Comment #5

rschwab commented 29 November 2010 at 17:24

Would a third link to "View all installed themes" make this work? (That is essentially what the post-theme install link does now).

Log in or register to post comments

Comment #6

Bojhan commented 29 November 2010 at 17:45

Why don't we say something along the lines of "Enable installed theme". Then it goes to the page where to enable, it might not be 100% correct but that is what the user is looking for, we don't "take" the action for modules - so I do not see why we would for themes. We can spend time making it sound technically correct though, for that calling the hub "Apperance" or so would already be sufficient.

I understand its the two things you want to do next, but this late in the stage we can't guess if thats also what everyone else wants to do - thereby my objection to add a "configure the installed theme" link.

Log in or register to post comments

Comment #7

rschwab commented 29 November 2010 at 17:59

The problem is that themes are enabled by the update module upon install already. A link to "Enable installed theme" is just as misleading, if not moreso, than "Set the theme as default". Both link texts are false, but at least the current text takes you to a page where you can take the action listed.

If we're going to punt on making these links more useful then I suggest we change the existing link text to "View installed themes". But to be honest I don't see how the two links in the patch above detract from usability.

Log in or register to post comments

Comment #8

rschwab commented 29 November 2010 at 19:30

Status	File	Size
new	updated-theme-links.patch	1.11 KB

Ok, this patch changes the links from:

"Set the X theme as default" (going to the theme list page)

to

"View installed themes" (going to the theme list page)
"Set the X theme as default" (sets the theme as default)
"Edit settings for the X theme" (going to the settings page for the new theme)

Since we don't really have time for proper user testing, I'm being presumptuous in suggesting we put our heads together to come up with what will most likely work best for this workflow. In my opinion, this patch is it. Any comments/suggestions?

Log in or register to post comments

Comment #9

Bojhan commented 29 November 2010 at 19:32

I am not sold, this late in the process changing to something less close to the users goal but technically more correct? We know what we want to do ideally (have a proper enable screen here), but we cant - so we cheat the text. I don't think there will be many issues from this, it leads you to the page where you can take the action - less optimal, but certainly not a critical usability issue of any kind.

What we want to do now is to avoid the user goal, to be more technically correct. I mean there is no taking sides on this one, its only bad choices - my bad choice is to go for the user goal.

For the sake of moving forward. We cannot change it here, and leave it incorrect at the module page. So I would love if you could tackle both and come up with sensible text. I think "View installed themes" is oke but its probably better to just say "Appereance" then - which triggers the same mental model - with less words.

Log in or register to post comments

Comment #10

Bojhan commented 29 November 2010 at 20:00

So lets go for :

Appereance.
Set the X theme as default.

My last offer :) I think the settings is really still redundant, its only an option for expert users who already know what they installed and how to leverage it and which configurations they want to set. Most others just want to see it on their site and then fiddle with settings. Bare in mind this option is still a bit of a UX cheat because ideally we want to go straight to Appereance and say "Your theme has been installed".

Also hopefully webchick and Dries will ignore that this won't be consistent with the module installer :)

Log in or register to post comments

Comment #11

rschwab commented 29 November 2010 at 21:26

Status	File	Size
new	updated-theme-links.patch	994 bytes

Attached patch implements #10.

The consistency issue runs much deeper, this is just triage for the impending string freeze.

Log in or register to post comments

Comment #12

dww

we/he/they

commented 29 November 2010 at 23:06

Note: I think it's weird (and I don't remember adding this) that Update manager automatically enables new themes. It doesn't do so with modules, why should it do so with themes? I'd be happy to simplify the choices here and remove the code that's auto-enabling. That behavior is already causing trouble, e.g. see #936490: Update module should verify downloaded tarballs and propagate errors correctly ...

Log in or register to post comments

Comment #13

rschwab commented 29 November 2010 at 23:11

FYI that is happening in system.updater.inc around line 139:

// Active the theme
    db_update('system')
      ->fields(array('status' => 1))
      ->condition('type', 'theme')
      ->condition('name', $this->name)
      ->execute();

Log in or register to post comments

Comment #14

rschwab commented 30 November 2010 at 00:05

Status	File	Size
new	theme-install-alt.patch	1.03 KB

Ok, this patch is an alternate to #11. It removes the code that auto-enables themes on install, and changes the "next step" to be the same as for modules, ie "Enable newly added themes".

Log in or register to post comments

Comment #15

dww

we/he/they

commented 30 November 2010 at 02:54

Status:

Needs review

» Reviewed & tested by the community

Untested, but visually #14 looks fantastic. ;) I can't see how that could hurt anything, it makes the Update manager more consistent, and makes the UI more simple. I was going to write and post the identical patch myself. So, RTBC...