Undefined property 'node_notify_mailalert', and node author never gets a notification

Same here, with 7.x-1.x-dev. But I only get the second error:
Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 440 of /srv/www/vladgh.com/sites/all/modules/comment_notify/comment_notify.module).

Regarding the second error:

Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 440 of /srv/www/vladgh.com/sites/all/modules/comment_notify/comment_notify.module).
I discovered that the "user_load" function on line 438

$author = user_load($node->uid);
dpm($author);

does not include a variable called "node_notify_mailalert" but it includes an array called "comment_notify_settings" with the following content:
- uid (String, 1 characters ) 1
- node_notify (String, 1 characters ) 1
- comment_notify (String, 1 characters ) 1

So, by changing "$author->node_notify_mailalert == 1" in line 440 with "$author->comment_notify_settings->node_notify == 1" everything seems to work. I am not sure though it this is the right way to do this.

I got the two same errors as in the original post for comments to forum posts in Drupal 7 RC3.

How to reproduce:

- Create a new forum topic
- Create a new comment to the above topic

In my case I had notification turned of for the user in both of the posts above.

Also changing version to -dev since that is the version I used.

I'm also experiencing the same as #2. Trying to suggested workaround.

I've created a patch from #2, which worked for me.

For me this solved the second problem, but I still get the first error message:

Notice: Undefined index: name in _comment_notify_mailalert() (Zeile 417 von /var/www/vhosts/mysite.com/subdomains/test/httpdocs/sites/all/modules/comment_notify/comment_notify.module).

Confirm this, i've got the same first message as a topic starter when posting a comment on new D7.

For me this solved the second problem, but I still get the first error message

same. sub.

I also get:
Notice: Undefined index: name in _comment_notify_mailalert() (line 417 of /sites/all/modules/comment_notify/comment_notify.module).

After I have posted a comment.

subscribe

For the Feb 25 dev version I'm getting this:

Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 433 of /home/develop/public_html/sites/all/modules/comment_notify/comment_notify.module).

I'm getting the same error in #12.

FWIW, the patch in #5 applied to the feb25 dev version worked for me. That should go into git.

(I'm working with a new D7 installation, not upgraded from D6.)

I haven't seen the error about the undefined "name" index. There IS a name field in the comment object, and I also tested some debug output statements to verify that it's there. Maybe it only happens under certain conditions?

I've been testing and creating patches for this module for D7, since I really need it to work asap.

I've attached patches to relevant bug tickets here on the drupal website, but if anyone wants to pull down my forked version from github, it's publicly available here:

https://github.com/codeforkjeff/comment_notify

In the future, if you mark issues "needs review" when there is a patch, people will probably review them faster :)

The important part of this bug is not the PHP notice, but rather the fact that the node author never gets the email (even when they checked the "Receive node follow-up notification e-mails" box on their user account page). Retitling, and also marking a couple other issues duplicate (since we have a working patch here), including:
#833452: Notification not sent for 1st comment, only replies
#1157692: Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 433
#1184280: Bug in node author handling in _comment_notify_mailalert()

I'm not sure if the module maintainer wants a test written here, but otherwise I think the patch is RTBC - it works and the code makes sense. (Actually, looking at the patch I don't think the $author->comment_notify_settings->node_notify == 1 check is really necessary when there was a !empty() check right before it, but on the other hand, that's exactly what the D6 version of the module does, so might as well keep it around.)

> Looking at the patch I don't think the $author->comment_notify_settings->node_notify == 1 check is really necessary when there was a !empty() check right before it

Re-rolled patch accordingly.

Thanks, that patch works too. Either one is RTBC, from my point of view :)

The patches are the same :)

Now committed http://drupalcode.org/project/comment_notify.git/commit/b646247

Thanks tobby, bricel, David_Rothstein!

Still getting the following error. I double checked, this patch is in place.

Notice: Undefined property: stdClass::$node_notify_mailalert in _comment_notify_mailalert() (line 440 of comment_notify/comment_notify.module).

Hrm, never mind.