If you disable the logo then the site name alignment goes out (too far left for LTR) compared with tabs and main body content.

These patches should fix the issue for LTR and TRL.

CommentFileSizeAuthor
#5 drupal-bartik-972136-5.patch1.42 KBtim.plunkett
#4 drupal-bartik-972136-4.patch1.42 KBtim.plunkett
#4 972136-after.png51.72 KBtim.plunkett
after.png14.04 KBjdelaune
before.png8.72 KBjdelaune
style-rtl.patch317 bytesjdelaune
style.patch537 bytesjdelaune

Comments

jdelaune’s picture

jdelaune commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, style-rtl.patch, failed testing.

jensimmons’s picture

jensimmons commented
Priority: Normal » Major

Embedding screenshots from above for faster reading.

BEFORE:
screenshot showing bug with title out of alignment.

AFTER:
title lining up

Also, bumping this to major, because I think it's a Top 5 Bartik bug.

(This wasn't a problem a while ago, it's a regression that was added to the mix at some point. Good catch!)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 7.0-beta3 » 7.x-dev
Status: Needs work » Needs review
StatusFileSize
new 972136-after.png51.72 KB
new drupal-bartik-972136-4.patch1.42 KB

This takes into account the changes made in #844734: Bartik, do not import style.css from preview.css. Also, I put the margin on #name-and-slogan, because the slogan suffers from the same issue when the logo is missing.

Keep in mind that the spacing in both of these patches is 15px, which is the padding for the blocks below as well as the ul. However, the links also have 2px of their padding, which is why they're offset a little.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new drupal-bartik-972136-5.patch1.42 KB

Just a reroll for offsets, no changes since last patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +jen's hit list
Jeff Burnz’s picture

Jeff Burnz commented

Not sure what is going on with the bot atm, but this is good to go - RTBC. Leaving as needs review status in case the bot kicks in and we get a green light.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

RTBC per Jeff's comment, testbot finally woke up.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -jen's hit list

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +jen's hit list

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.