description = is not escaped for JS. So, we need to check the box for bad judgement and submit the form, thus auto-enabling the module when the modules page is visited

CommentFileSizeAuthor
#3 you-asked-for-it-971858-3.patch2.37 KBJohnAlbin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented

Dont forget to submit back the form.

chx’s picture

chx CreditAttribution: chx commented

Oh Dmitri wrote that already. Too baaaaaaad :p

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Reviewed & tested by the community » Needs review
FileSize
you-asked-for-it-971858-3.patch2.37 KB

Ok. Here's a patch.

carlos8f’s picture

carlos8f CreditAttribution: carlos8f commented

LOL. +1

mbutcher’s picture

mbutcher CreditAttribution: mbutcher commented
Status: Needs review » Reviewed & tested by the community

Tested, and I can verify that this patch was "rolled" like no other.

IceCreamYou2’s picture

IceCreamYou2 CreditAttribution: IceCreamYou2 commented

Wait, does this mean the module can never be disabled from the UI? What if someone installs a bad idea, realizes it's a bad idea, and then wants to remove it?

...oh, I get it.

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented

@JohnAlbin you are amazing

carlos8f’s picture

carlos8f CreditAttribution: carlos8f commented

Can haz?

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Version: 7.x-1.0-rc39 » 8.x-1.0
Status: Reviewed & tested by the community » Needs review

Fixed.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Needs work

The patch is missing critical functionality: it cannot commit itself.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

This is AWESOME :D

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
CreditAttribution: wizonesolutions commented
Assigned: dmitrig01 » Unassigned
Issue tags: +SUPER URGENT

Has any body gotten the self comiting paches 2 werk? I ned this for a client. They insissted I use Bad Judgement on there sight.

danillonunes’s picture

danillonunes CreditAttribution: danillonunes commented

If there two modules, like Module A and Module B, where:

Module A depends on Module B
&&
Module B depends on Module A

Then when them both are enabled, they cannot be disabled due to inter-dependency (on the interface, the checkboxes are disabled).

I think that can be used to ensure that a bad decision cannot be rolled back.