In Drupal 6 and 7, aggregator module ignores the Atom entry <id> element. It should instead treat Atom entry <id> as equivalent to the RSS item <guid> element.

Files: 
CommentFileSizeAuthor
#10 aggregator-atom-id-971812.patch733 bytestwistor
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View
#2 atom-id.d7.patch1.7 KBmfb
PASSED: [[SimpleTest]]: [MySQL] 27,357 pass(es). View
#1 atom-id.d7.patch862 bytesmfb
PASSED: [[SimpleTest]]: [MySQL] 27,348 pass(es). View
atom-id.d6.patch918 bytesmfb

Comments

mfb’s picture

Version: 6.x-dev » 7.x-dev
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
862 bytes
PASSED: [[SimpleTest]]: [MySQL] 27,348 pass(es). View
mfb’s picture

Issue tags: -Needs tests
FileSize
1.7 KB
PASSED: [[SimpleTest]]: [MySQL] 27,357 pass(es). View

add a test which fails without this patch.

TheoRichel’s picture

subscribe

verta’s picture

subscribe

TheoRichel’s picture

I have tried the D6 version and I am a happy man, it works! Thanks very much!

twistor’s picture

Status: Needs review » Reviewed & tested by the community
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

mfb’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Needs review

The d6 version of the patch is in the initial post.

mfb’s picture

Ping. Looks like this patch didn't make it into Drupal 6.22 :(

twistor’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
733 bytes
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View

Re-rolled initial patch to apply without p0.

Other than that, it's golden.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.