Radio button values get run through check_plain() twice [#971120]

Radio elements' #return_value attributes do not need to be run through check_plain() in form_process_radios(), since the attribute is ultimately output by drupal_attributes(), which runs all attribute data through check_plain() itself.

This messes up any javascript that looks at form element values--probably #states and definitely ctools form dependencies (#958608: Dependendcy does not work with option "<=").

Patch attached.

Comment	File	Size	Author
#11	971120.patch	4.1 KB	bojanz
#11
#7	971120.patch	3.58 KB	bojanz
#7
#5	971120-5-radio_values.patch	2.96 KB	dawehner
#5
#4	971120-4-radio_values.patch	1.24 KB	becw
#4
#2	971120-2-radio_values.patch	1.21 KB	becw
#2
	radio_values.patch	1.21 KB	becw

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 November 2010 at 01:50

Status:

Needs review

» Needs work

The last submitted patch, radio_values.patch, failed testing.

Comment #2

becw CreditAttribution: becw commented 14 November 2010 at 03:29

Status:

Needs work

» Needs review

File	Size
971120-2-radio_values.patch	1.21 KB

Checking for actual equivalency this time...

Comment #3

14 November 2010 at 04:00

Status:

Needs review

» Needs work

The last submitted patch, 971120-2-radio_values.patch, failed testing.

Comment #4

becw CreditAttribution: becw commented 14 November 2010 at 05:37

Status:

Needs work

» Needs review

File	Size
971120-4-radio_values.patch	1.24 KB

Absolute equivalency wasn't the issue--need to check whether the element has a value or not. Thx simpletest!

Comment #5

dawehner

German

CreditAttribution: dawehner commented 14 November 2010 at 09:34

File	Size
971120-5-radio_values.patch	2.96 KB

Here is patch with a test. But sadly this testcase in general fails here, let's see what the testbot says.

Comment #6

bojanz CreditAttribution: bojanz commented 25 December 2010 at 14:19

The test without the fix fails, as it should.
Let's see if the testbot is still happy with the patch.

#5: 971120-5-radio_values.patch queued for re-testing.

Comment #7

bojanz CreditAttribution: bojanz commented 25 December 2010 at 17:38

File	Size
971120.patch	3.58 KB

Great, the bot still likes it!

Rerolled anyway, adding commas at the end of newly added array elements, and eliminating the offsets while I'm at it.

+1 for RTBC.

Comment #8

bojanz CreditAttribution: bojanz commented 26 December 2010 at 00:31

chx pointed me to #954628: "An illegal choice has been detected" when a radio/checkbox option key contains a quote character.
The fix for radio buttons in that issue is the same one as the one in this patch, except that this patch also has tests.
Before that issue can be closed and this one committed, we need to see what should be done with checkboxes, since they might have a similar bug of their own.