nojs/ajax replacement fails in various situations [#970536]

Currently "nojs" in the path is used to gracefully degrade if users don't have javascript. However, the javascript regex that replaces that with "ajax" is finicky and doesn't allow for variations in the URL, such as query parameters or fragments. Here is the list of cases it should check for:

+  // 1. /nojs/
+  // 2. /nojs$ - The end of a URL string.
+  // 3. /nojs? - Followed by a query (with clean URLs enabled).
+  //      E.g.: path/nojs?destination=foobar
+  // 4. /nojs& - Followed by a query (without clean URLs enabled).
+  //      E.g.: ?q=path/nojs&destination=foobar
+  // 5. /nojs# - Followed by a fragment.
+  //      E.g.: path/nojs#myfragment

This is a backport of #565808: nojs/ajax replacement from Drupal HEAD.

Comment	File	Size	Author
#13	ctools_970536.patch	2.4 KB	Demonick99
#3	ctools_970536.patch	2.39 KB	drewish
#2	ctools_970536.patch	84.74 KB	drewish
	nojs-ajax-replace-d6.patch	2.44 KB	carlos8f

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drewish CreditAttribution: drewish commented 2 February 2011 at 17:05

I appreciate that this moves the regex into a function. I'd be able to re-use it from Dialog module. We're currently debating what the right regex is for rewriting links. Currently it matches ctools but Dave Reid is pushing for the D7 mechanism: #1046758: Drupal.Dialog.submitAjaxForm not correctly rewriting URLs.

Comment #2

drewish CreditAttribution: drewish commented 2 February 2011 at 17:27

File	Size
ctools_970536.patch	84.74 KB

I poked around with panels with the debugger and seemed good to me, I couldn't find any regressions.

I rerolled the patch to remove an extra semicolons from one line:

+        url = Drupal.CTools.AJAX.urlReplaceNojs(url);;

Comment #3

drewish CreditAttribution: drewish commented 2 February 2011 at 17:29

File	Size
ctools_970536.patch	2.39 KB

Yeah, ignore the other 82K of that patch.

Comment #4

Taran2L

Ukrainian

Lviv

CreditAttribution: Taran2L commented 16 February 2011 at 18:56

@drewish: thanks, seems like your patch works properly.

Comment #5

Blackice2999 CreditAttribution: Blackice2999 commented 13 May 2011 at 13:45

Hi,

same strange issue here on Firefox 3.6.17 i applied the patch and the problem is still exists and firefox calls nojs instead of ajax. The interesting is if i open the firebug (only open firebug no more) it works nojs will be replaced with ajax. if i close firebug its work until a page reload... i think this is a strange firefox issue and its hard to debug it without firebug :D

regards
Dennis

Comment #6

Taran2L

Ukrainian

Lviv

CreditAttribution: Taran2L commented 16 May 2011 at 11:34

@Blackice2999, probably you have console.log() somewhere in the code (or other console object use), without Firebug there are no console object in FF. In this case you will have uncaught JS error, which can break other code, like ctools AJAX responder.