theme_languageicons_icon() > Please use that function, to support cdn.

CommentFileSizeAuthor
#5 969722-04-use_theme_image_to_render_icons-d7.patch1.57 KBFreso
#2 969722-use_theme_image_to_render_icons-02-d7.patch1.53 KBFreso
#1 969722-use_theme_image_to_render_icons-01-d6.patch1.51 KBFreso

Comments

Freso’s picture

Freso commented
Title: Use theme_image to render images » Use theme_image to render icons
Assigned: Unassigned » Freso
Status: Active » Needs review
StatusFileSize
new 969722-use_theme_image_to_render_icons-01-d6.patch1.51 KB

I just tried implementing this feature request on 6.x-2.x. Please try the attached patch and report back whether it works. (I haven't tried it out meself.)

Freso’s picture

Freso commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
StatusFileSize
new 969722-use_theme_image_to_render_icons-02-d7.patch1.53 KB

And the patch for 7.x-1.x.

thehong’s picture

thehong commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Patch look good, please commit to stable branch first.

Freso’s picture

Freso commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review

No, patches always go to HEAD first. Also, did you try/test the patch or just review it? I'll need the former before I'll apply it. (It's okay if you only test 6.x-2.x though, as 7.x-1.x isn't fully working at the moment.)

Freso’s picture

Freso commented
Title: Use theme_image to render icons » Use theme_image() to render icons
Version: 7.x-1.x-dev » 6.x-2.x-dev
StatusFileSize
new 969722-04-use_theme_image_to_render_icons-d7.patch1.57 KB

The patch didn't work, but this one does, and was thus committed. :)

Now I just need either a proper review of the patch for 6.x-2.x, or some time to test it myself. (My focus is mainly on getting Language icons ready for D7, so I cannot say when I'll have time for that right now.)

Freso’s picture

Freso commented
Status: Needs review » Fixed

And finally patched up the D6 version and committed it to the 6.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.