The sign in button on the login form uses a html list, which seems unnecessary for what is one link/button.

This also looks unusual unless you theme out the list style image and padding with CSS.

Comments

agileware’s picture

Also, there are no css classes on the list that can be used to easily change the appearance of this link.

houstonaplus’s picture

try this on your css stylesheet as it works on our site:

form#user-login .item-list ul li {
list-style: none;
padding: 0px;
margin:0px;
}
agileware’s picture

That is pretty much what I have but it isn't ideal because what if there are other item lists on that form that I want to leave alone.

For this reason it would still be better if there was a specific class for this.

akolahi’s picture

I agree. A specific class would be very helpful in my case as well. There are other items that are affected when I try to theme the button.

akolahi’s picture

To be more specific, in the standard sign in block, the language "Create new account" and "Request new password" are also affected by

form#user-login .item-list ul li

reallyordinary’s picture

Just chiming in - it would be really, really great to have a css class for the sign in button. Would make life a lot easier when theming.

reallyordinary’s picture

I figured out a way to select the sign-in button.

a[href="/twitter/redirect"] {css styling info goes here}

I've managed to use that to separate it from the create new account and request new password links so I can position it independently. Seems to work.

steinmb’s picture

Version: 6.x-3.0-beta3 » 6.x-3.x-dev

Hi
There have been some work done to help out front end guys http://drupalcode.org/project/twitter.git/commit/02049c7 fixing [#736698 Test it, try overriding, post your comments. We are open for suggestions and patches regarding the signin button.

caligari’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new2.36 KB

This patch adds class attribute to the link-button and an option in the admin menu to configure the button also a text (instead an image).

The CSS class is named 'twitter-signin-menuitem'. Other extra class 'twitter-signin-menuitem-just-text' or 'twitter-signin-menuitem-image' indicates if the link-button is text or image.

warmth’s picture

I agree, lists for this should be optional (maybe can be used by other modules like Drupal for Facebook to place its button). In other hand an option to decide where to put the button (before the inputs or after) and a custom image to upload one would be great too.

Patch #9 applied correctly here.

13rac1’s picture

Version: 7.x-3.x-dev » 7.x-5.x-dev
Status: Needs review » Reviewed & tested by the community

Patch applies with fuzz on 7.x-5.x. Works for #10 and looks good here.

 $ git apply twitter-fixed-969454-3698716_0.patch 
error: patch failed: twitter_signin/twitter_signin.module:65
error: twitter_signin/twitter_signin.module: patch does not apply
error: patch failed: twitter_signin/twitter_signin.pages.inc:14
error: twitter_signin/twitter_signin.pages.inc: patch does not apply
 $ patch -p1 < twitter-fixed-969454-3698716_0.patch 
patching file twitter_signin/twitter_signin.module
Hunk #1 succeeded at 69 with fuzz 1 (offset 4 lines).
patching file twitter_signin/twitter_signin.pages.inc
Hunk #1 succeeded at 17 with fuzz 1 (offset 3 lines).
damienmckenna’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release

Triggering the testbot.

Status: Needs review » Needs work

The last submitted patch, 9: twitter-fixed-969454-3698716.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: twitter-fixed-969454-3698716.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new1.9 KB

Rerolled.

damienmckenna’s picture

Status: Needs review » Fixed

Committed to the 7.x-5.x and 7.x-6.x branches. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.