Closed (fixed)
Project:
Twitter
Version:
7.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Nov 2010 at 00:40 UTC
Updated:
25 Jul 2015 at 21:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
agileware commentedAlso, there are no css classes on the list that can be used to easily change the appearance of this link.
Comment #2
houstonaplus commentedtry this on your css stylesheet as it works on our site:
Comment #3
agileware commentedThat is pretty much what I have but it isn't ideal because what if there are other item lists on that form that I want to leave alone.
For this reason it would still be better if there was a specific class for this.
Comment #4
akolahi commentedI agree. A specific class would be very helpful in my case as well. There are other items that are affected when I try to theme the button.
Comment #5
akolahi commentedTo be more specific, in the standard sign in block, the language "Create new account" and "Request new password" are also affected by
form#user-login .item-list ul liComment #6
reallyordinary commentedJust chiming in - it would be really, really great to have a css class for the sign in button. Would make life a lot easier when theming.
Comment #7
reallyordinary commentedI figured out a way to select the sign-in button.
a[href="/twitter/redirect"] {css styling info goes here}
I've managed to use that to separate it from the create new account and request new password links so I can position it independently. Seems to work.
Comment #8
steinmb commentedHi
There have been some work done to help out front end guys http://drupalcode.org/project/twitter.git/commit/02049c7 fixing [#736698 Test it, try overriding, post your comments. We are open for suggestions and patches regarding the signin button.
Comment #9
caligari commentedThis patch adds class attribute to the link-button and an option in the admin menu to configure the button also a text (instead an image).
The CSS class is named 'twitter-signin-menuitem'. Other extra class 'twitter-signin-menuitem-just-text' or 'twitter-signin-menuitem-image' indicates if the link-button is text or image.
Comment #10
warmth commentedI agree, lists for this should be optional (maybe can be used by other modules like Drupal for Facebook to place its button). In other hand an option to decide where to put the button (before the inputs or after) and a custom image to upload one would be great too.
Patch #9 applied correctly here.
Comment #11
13rac1 commentedPatch applies with fuzz on 7.x-5.x. Works for #10 and looks good here.
Comment #12
damienmckennaTriggering the testbot.
Comment #16
damienmckennaRerolled.
Comment #19
damienmckennaCommitted to the 7.x-5.x and 7.x-6.x branches. Thanks.