The menu from Contextual Links stays visible on top of Overlay content possibly obscuring content when using Bartik in combination with Seven. Problem seen on both the iPhone (4.1 8B117) and iPad (4.2 8C134). Screen shot attached. Problem not present when using Garland in combination with Seven.

CommentFileSizeAuthor
#4 drupal-964882-4.patch998 bytestim.plunkett
foto.PNG36.43 KBmo6

Comments

jgottwig’s picture

jgottwig commented

I can actually duplicate this on all desktop browsers I've tested as well, but it disappears as soon as I move the mouse off the link (so I'm guessing this is a mouse-based vs. finger-based interface issue). Does it remain visible after you tap elsewhere on the overlay?

mo6’s picture

mo6
he/him
Primary language Dutch
commented

It remains visible when clicking elsewhere on the overlay. The menu can be closed by clicking on the down array from the contextual menu, though. After closing the contextual menu wheel and array stay visible, obscuring content from the overlay.

mark trapp’s picture

mark trapp
he/him
Primary language English
commented

Tagging.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Component: Bartik theme » contextual.module
Status: Active » Needs review
StatusFileSize
new drupal-964882-4.patch998 bytes

The bug is in contextual.js, not Bartik. The contextual links currently only disappear when the mouse leaves the region, which isn't compatible with the way iOS implements gestures. However, it is also a "bug" in regular browsers, because the links won't disappear until the mouse leaves.

The fix is to bind the mouseleave code to both mouseleave and click.

At least 50% credit goes to canarymason!

jensimmons’s picture

jensimmons commented

sub

mark trapp’s picture

mark trapp
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Works as advertised. Checked with an iPad using iPhone OS 3.2 and iOS 4.2 as well as an iPhone using iPhone OS 3.1.3 and iOS 4.2. Also fixes the behavior in Safari 3-5, FIrefox 1.5-3.6, and Opera 9.27-10.63.

mo6’s picture

mo6
he/him
Primary language Dutch
commented

I can confirm that the patch works as advertised, both on iPad and iPhone running iOS 4.2.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.