Hi,

It's a follow-up from #809276: Error after enabling simplenews and actions. I replaced hook_hook_info() by hook_trigger_info().
I think it could be the occasion to rename it simplenews_action_trigger_info() instead of simplenews_trigger_info(), but leave the decision to the maintainer.

There still are a few things not working in the module (like the configuration of advanced actions), but we'll get there eventually ;)

Best regards,
Simon

CommentFileSizeAuthor
#3 simplenews_964614_3_action.patch8.01 KBmiro_dietiker
#1 simplenews_964614_action.patch8.27 KBmiro_dietiker
simplenews_trigger_info.patch1.01 KBsimon georges

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new simplenews_964614_action.patch8.27 KB

Glad to see you working on this.
Since this functionality is omitted by simplenews itself and it's introduced by the simplenews_action module i consider clearly using the new simplenews_action namespace.

What do you think of prefixing all functions as suggested by my patch?
Please review and conform to commit.

simon georges’s picture

simon georges commented

I'd agree about everything but simplenews_action_cron(), because it would be interpreted by drupal as the hook_cron() for this module, so I think we have to use a different name for this one. Otherwise, good for me (apart from the fact that you still need the patch on #809276: Error after enabling simplenews and actions to have everything working ;)).

I'll do an extensive review to look for other bugs after the next commit(s).
Anyway, maybe you'd rather focus on releasing the 6.x-2.x version for now, it seems we still have a few months before the D7 stable release, and simplenews D7 port is already well advanced. Just contact me if you need any further or specific help. I like this module ;)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new simplenews_964614_3_action.patch8.01 KB

Attached patch is the second try after the other one was committed.
Please review again.

simon georges’s picture

simon georges commented

This one sounds good ;)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.