When nodereference_variables_return_nodes() prepares the referenced nodes it doesn't currently check whether they are published or unpublished. This means that unpublished nodes get included as tabs.

I'm working on a patch and will post it shortly.

CommentFileSizeAuthor
#2 nodereference_variables-check_unpublished_1.patch729 bytessteveparks
#1 nodereference_variables-check_unpublished.patch1.33 KBsteveparks

Comments

steveparks’s picture

steveparks commented
Status: Active » Needs review
StatusFileSize
new nodereference_variables-check_unpublished.patch1.33 KB

Initial patch attached

steveparks’s picture

steveparks commented
StatusFileSize
new nodereference_variables-check_unpublished_1.patch729 bytes

Corrected patch

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs review » Reviewed & tested by the community

Thanks, Steve. Will apply asap...

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Assigned: Unassigned » greg.harvey
Status: Reviewed & tested by the community » Postponed

Hmm, seems the version of the module this was patched for is quite out of sync with current -dev. I suspect this is my fault and I made improvements on the client project without updating dev (and Steve patched against the client project). I need to merge changes before this patch can be applied.

slv_’s picture

slv_ commented
Status: Postponed » Closed (fixed)

After merging the client version of code, with the improvements made, it seems this is already fixed there, so makes no sense to apply this, as basically there's nothing to apply now =).

Marking as closed (fixed)