In README.txt I see: In addition, before this is actually utilized you can use hook_panels_everywhere_contexts(&$contexts, $placeholders).
Is this hook supposed to work? It does not for me and I don't see it in code of Panels Everywhere. Maybe it's just outdated documentation or I am doing something wrong. Nothing happens with code below.
function MODULENAME_panels_everywhere_contexts(&$contexts, $placeholders) {
dsm($contexts);
dsm($placeholders);
}
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | panels_everywhere_context_alter-962122-10.patch | 1.22 KB | stevector |
| #6 | docs_fix_962122_6.patch | 608 bytes | Letharion |
Comments
Comment #1
henrijs.seso commentedis this the same?
_page_manager_contexts_alter(&$contexts, $placeholders)Comment #2
merlinofchaos commentedAh yes. It appears the README.txt misnames the hook. It's an _alter:
So that would be hook_page_manager_contexts_alter(&$contexts, $placeholders);
Comment #3
henrijs.seso commentedI am testing PA and it appears the docs are off, ill try to provide update when I wrap my mind around it :)
Comment #4
Letharion commentedAnswered by merlin.
Comment #5
merlinofchaos commentedIt sounds like there's a doc update needed here.
Comment #6
Letharion commented@merlinofchaos
Would you please verify that this gets it right? :)
Comment #7
Letharion commentedComment #8
merlinofchaos commentedYou know, I think the documentation is right and the code is wrong.
the drupal_alter call should be adjusted. This really is a panels_everywhere specific set of contexts and should be namespaced accordingly.
Comment #9
Letharion commentedComment #10
stevectorThis naming inconsistency is present in 7.x as well. Here's a patch.
This is an API change. I'm not sure if rc1 is too late for that. If so, Panels Everywhere could call both alter hooks and document the discrepancy.
Comment #11
damienmckennaI don't think this needs any further work, e.g. more documentation, but it gets a +1 from me.
Comment #14
damienmckennaI'm committing it as-is, but I'll need to do a change notice before the 1.0 release.
Comment #15
damienmckennaComment #16
damienmckennaI've created a draft change record, it'll be published along with 1.0.