Fatal error: Call to undefined function _upload_file_limits() in modules/taxonomy_xml/taxonomy_xml.module on line 505

This is related to #447796: Fatal error: Call to undefined function _upload_file_limits() in modules\taxonomy_xml\taxonomy_xml.module on line 393, #791378: improper use of file_validate_extensions on upload and #338925: improper use of file_validate_extensions on upload. Since 447796 was closed I opened this issue, some projects don't like reopening of old issues, and I don't know if there is a sitewide, or module specific rule on this.

Sorry if it is inappropriate to open a new issue, instead of reopening the old.

Comments

dman’s picture

dman CreditAttribution: dman commented
Status: Active » Fixed

Yeah. Thanks for pulling those related issues together in a list. It was a bit of a head-scratcher.

Was a trade of between:
Potentially allowing people to upload unknown files - by virtue of their 'admin taxonomy' rights ( = dangerous)
vs
Limiting those folk to a known set of file types, yet not allowing that list to be adapted. (maybe limiting)
vs
Building a UI somewhere else just to manage the list of allowed file types (= boring and rarely used)
vs
Re-using a UI that already provides that feature securly and assuming that core is doing it right ( = seemed the best bet)

However. Solution #4 seems to have caused issues, so now I've gone with #2:
Removed unneccessary dependency/assumption of upload.module. Resolved security limitation. UID #1 can upload anything. Others with admin taxonomy rights can upload [txt csv xml rdf]. No tweaking allowed, no UI needed.

http://drupal.org/cvs?commit=480600
6.x-2.x-dev only
For anyone else ... well, just use the tool as UID #1 - that was the expectation.
Or rename your files to .txt

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ñull’s picture

ñull CreditAttribution: ñull commented
Status: Closed (fixed) » Active

I followed the hyperlinks from 1.2 via 1.3 until I ended up here. It is marked fixed, but in 1.3 it is still there and that happens to be the recommended version. Please apply this patch to 1.3 and release 1.4 or come out with a 2.0 release as recommended.

dman’s picture

dman CreditAttribution: dman commented

Yeah, we are probably due for a 2.0 release. I've been doing LOTS to it, and it's feeling stable to me

dman’s picture

dman CreditAttribution: dman commented
Status: Active » Fixed

http://drupal.org/node/1048676 - 2.0 release.
May have issues, but also has many improvements.
Now it's (sorta) out of -dev status, raise any individual issues you encounter, and supply the source data you were trying to import.

Closing this issue as the new release was requested -any bugs are new issues against the new release, please supply full samples of anything that causes it to break.

As before, the assumption is that this is an ADMIN sort of operation, so if you want unprivileged users to use this tool, please explain the use-case.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.