Node module key doesn't actually need to correspond to anything (I believe that PDD book suggests using something other than module name for it in it's examples -- haven't read it but someone mentioned something like that), and also if module_key == current module, it gets added O.O!

CommentFileSizeAuthor
module_key_is_a_ruse.patch774 byteshefox

Comments

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Confirmed patch applies. hefox, you're a co-maintainer now so you can just RTBC and commit if this is still worth it. Right? :D

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community

Yep, for tiny patches like this one review seems good enough. Getting ready for a labour day dinner, so later :P

hefox’s picture

hefox commented
Status: Reviewed & tested by the community » Fixed

d7 now has the 'base' key now and 'module' corresponds to defining module (http://api.drupal.org/api/drupal/modules--node--node.module/function/_no...) and not directly from the code, so as far as I can tell this doesn't need to be ported.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.