Consider making forum folder CSS more specific

Nothing I can do from AF if the theme overrides the background images on the table. Moving this to the Blueprint theme queue.

Michelle

Michelle & MasterChief,

How about something like the attached. Does that take care of the issues? I've never used forums in production and never downloaded advanced_forums before today so I don't know what all it does but the basic icon overrides seem to be taken care of.

Please look over the patch and let me know if that works for you.

-Brent

You might want to try clearing your theme cache via Drush (drush cc theme) or by visiting the theme page. I tried that and it seemed to work fine, as far as I could tell.

That's strange as on my test site when I apply the patch above and have Advanced Forums running, the icons do change.

Alright, after playing around with it, I think I have found the icons you are referring to. The problems comes down to the way that not just Blueprint the theme handles it but the way that Blueprint the framework handles it. I don't have control over the framework. The offending rule is as follows:

tr.even td {
background:none repeat scroll 0 0 #E5ECF9;
}

There are two ways to fix it:

1. First would be to add the styles to your custom style sheet. You would need to add something like the following:

   .forum-folder, tr.even td.forum-folder, tr.odd td.forum-folder {
     background: transparent url(images/forum-folder.png) no-repeat center center;
   }
   
   .forum-folder, tr.even td.forum-folder-new-posts, tr.odd td.forum-folder-new-posts {
     background: transparent url(images/forum-folder-new-posts.png) no-repeat center center;
   }
   
   .forum-folder, tr.even td.forum-folder-locked, tr.odd td.forum-folder-locked {
     background: transparent url(images/forum-folder-locked.png) no-repeat center center;
   }

   except that you will need to either relink to the correct images or move the images into your theme folder.

2. The other option would be to patch Advanced forums with the attached patch that will override the Blueprint themes CSS files. Ultimately it would be helpful to get Michelle to commit this patch to her Advanced forums module but that is up to her.

I hope that helps.

I'm waffling... My first thought was that I don't want to patch AF with something to override one theme. On the other hand, this isn't really Blueprint specific CSS, just making the CSS more specific. So it probably wouldn't hurt. I'm pulling this back to my queue so I don't forget about it and will look into it further the next time I work on AF.

Michelle

Thanks for looking at that. If there was some way to override it on my end, I'd be happy to try that but after playing with it and looking at it, I realized that i couldn't find a way and the best place to be would be in the Advanced Forums theme.

I'll be adding the following patch that sidesteps all the forum_* overrides if advanced_forum exists.

Well, it's your call, of course, but I think it makes less sense for you to put a conditional check for AF in your theme than for me to add more specific markup to AF. :)

Michelle

Well, it's a two step problem. First is that I am overriding a bunch of forum functions. The second is the specificity of the css of your module. In a future version, I may pull out much of this theme code. I have left it in because I rarely use it and haven't wanted to deal with it. The prior maintainer put it in to start with. For now, I'll patch my part.

Committed, thanks. Tested to be sure the forum folders still show up under Garland but not tested to see if the patch had any effect on Blueprint.

Michelle

There's lots of problems with the current dev. It's still in really rough shape. I'm working on it as much as I can.

Michelle