Problem

  • Links in a standard list of links appear next to each other.

Goal

  • Only HTML lists having the .inline CSS class applied on the list should make the items appear next to each other.
Files: 
CommentFileSizeAuthor
#10 960490-fix-bartik-tabs.patch1.23 KBcarlos8f
FAILED: [[SimpleTest]]: [MySQL] 27,038 pass(es), 1 fail(s), and 0 exception(es). View
#8 960490-8.patch532 bytesJacine
PASSED: [[SimpleTest]]: [MySQL] 27,061 pass(es). View
#7 drupal7-padding.png22.46 KBradoeka
#6 960490_floating_tabs.patch488 bytesSivaji
PASSED: [[SimpleTest]]: [MySQL] 26,980 pass(es). View
#6 960490_floating_tabs_no_whitespace.patch2.28 KBSivaji
PASSED: [[SimpleTest]]: [MySQL] 27,034 pass(es). View
#5 20101107-8r5aewuitmw2uwy6t4n8eda16c.png75 KBDamien Tournoud
#2 960490.patch4.15 KBJacine
PASSED: [[SimpleTest]]: [MySQL] 26,775 pass(es). View

Comments

Jacine’s picture

Assigned: Unassigned » Jacine

Yeah, this is a really annoying bug. I'll work on a patch.

Jacine’s picture

Assigned: Jacine » Unassigned
Status: Active » Needs review
FileSize
4.15 KB
PASSED: [[SimpleTest]]: [MySQL] 26,775 pass(es). View

Here's a patch :)

PS - I added examples to markup_test to test this.

sun’s picture

Status: Needs review » Reviewed & tested by the community

yay, thanks! Tested manually - sanity is restored, perfect!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Damien Tournoud’s picture

Priority: Normal » Critical
Status: Fixed » Active
FileSize
75 KB

Interesting new graphical pattern, the "floating tabs".

Sivaji’s picture

Status: Active » Needs review
FileSize
2.28 KB
PASSED: [[SimpleTest]]: [MySQL] 27,034 pass(es). View
488 bytes
PASSED: [[SimpleTest]]: [MySQL] 26,980 pass(es). View

Removing surplus padding in themes/bartik/css/style.css, #main-menu-links fixed this issue for me. Attached patch will do the needful, tested against Firefox 4 beta, chrome 7 and opera 10 for Ubuntu.

BTW, style.css has trailing white spaces (see 960490_floating_tabs_no_whitespace.patch) is it acceptable ?

radoeka’s picture

FileSize
22.46 KB

With the patch in #6 the first tab is moved to the left, and looks not aligned with the rest of the page.

Shouldn't the patch be:
current: padding: 0 15px;
new: padding-left: 15px;

Either way padding 0 15px and padding-left works for me. FF-3.6.12.

The attachment (drupal7-padding.png) shows the result of the different options.
(ps: what to do, to show the image in the comment, is that possible for me?)

Jacine’s picture

Component: markup » Bartik theme
FileSize
532 bytes
PASSED: [[SimpleTest]]: [MySQL] 27,061 pass(es). View

Sorry, didn't test this in Firefox. My mistake.

@sivaji The padding is not excess. There should be 15px on both the right and the left, so it lines up with everything else.

Here's a patch to fix it.

Damien Tournoud’s picture

Status: Needs review » Reviewed & tested by the community

Ah. At last a patch that actually makes sense :)

carlos8f’s picture

Component: Bartik theme » markup
Status: Reviewed & tested by the community » Needs review
FileSize
1.23 KB
FAILED: [[SimpleTest]]: [MySQL] 27,038 pass(es), 1 fail(s), and 0 exception(es). View

I think the underlying problem is that in #903460: Bartik Tabs broken in Firefox, Jeff Burnz refactored the Bartik tabs to use "good old-fashioned" floats rather than display:inline, yet we've given the menu the inline class in this issue. I sent the patch through browsershots.org and the tabs are now positioned correctly.

Jacine’s picture

Component: markup » Bartik theme
Status: Needs review » Reviewed & tested by the community

#10 is fine with me. Works just as well.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 960490-fix-bartik-tabs.patch, failed testing.

carlos8f’s picture

Status: Needs work » Reviewed & tested by the community

Appears that HEAD is still broken.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.