Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
Bartik theme
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Nov 2010 at 21:56 UTC
Updated:
25 Nov 2010 at 19:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
jacineYeah, this is a really annoying bug. I'll work on a patch.
Comment #2
jacineHere's a patch :)
PS - I added examples to markup_test to test this.
Comment #3
sunyay, thanks! Tested manually - sanity is restored, perfect!
Comment #4
dries commentedCommitted to CVS HEAD.
Comment #5
damien tournoud commentedInteresting new graphical pattern, the "floating tabs".
Comment #6
sivaji_ganesh_jojodae commentedRemoving surplus padding in
themes/bartik/css/style.css, #main-menu-linksfixed this issue for me. Attached patch will do the needful, tested against Firefox 4 beta, chrome 7 and opera 10 for Ubuntu.BTW, style.css has trailing white spaces (see 960490_floating_tabs_no_whitespace.patch) is it acceptable ?
Comment #7
radoeka commentedWith the patch in #6 the first tab is moved to the left, and looks not aligned with the rest of the page.
Shouldn't the patch be:
current: padding: 0 15px;
new: padding-left: 15px;
Either way padding 0 15px and padding-left works for me. FF-3.6.12.
The attachment (drupal7-padding.png) shows the result of the different options.
(ps: what to do, to show the image in the comment, is that possible for me?)
Comment #8
jacineSorry, didn't test this in Firefox. My mistake.
@sivaji The padding is not excess. There should be 15px on both the right and the left, so it lines up with everything else.
Here's a patch to fix it.
Comment #9
damien tournoud commentedAh. At last a patch that actually makes sense :)
Comment #10
carlos8f commentedI think the underlying problem is that in #903460: Bartik Tabs broken in Firefox, Jeff Burnz refactored the Bartik tabs to use "good old-fashioned" floats rather than display:inline, yet we've given the menu the inline class in this issue. I sent the patch through browsershots.org and the tabs are now positioned correctly.
Comment #11
jacine#10 is fine with me. Works just as well.
Comment #13
carlos8f commentedAppears that HEAD is still broken.
Comment #14
dries commentedCommitted to CVS HEAD. Thanks.