Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem
- Links in a standard list of links appear next to each other.
Goal
- Only HTML lists having the
.inlineCSS class applied on the list should make the items appear next to each other.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 960490-fix-bartik-tabs.patch | 1.23 KB | carlos8f |
| #8 | 960490-8.patch | 532 bytes | Jacine |
| #7 | drupal7-padding.png | 22.46 KB | radoeka |
| #6 | 960490_floating_tabs.patch | 488 bytes | Sivaji_Ganesh_Jojodae |
| #6 | 960490_floating_tabs_no_whitespace.patch | 2.28 KB | Sivaji_Ganesh_Jojodae |
Comments
Comment #1
JacineYeah, this is a really annoying bug. I'll work on a patch.
Comment #2
JacineHere's a patch :)
PS - I added examples to markup_test to test this.
Comment #3
sunyay, thanks! Tested manually - sanity is restored, perfect!
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD.
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedInteresting new graphical pattern, the "floating tabs".
Comment #6
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedRemoving surplus padding in
themes/bartik/css/style.css, #main-menu-linksfixed this issue for me. Attached patch will do the needful, tested against Firefox 4 beta, chrome 7 and opera 10 for Ubuntu.BTW, style.css has trailing white spaces (see 960490_floating_tabs_no_whitespace.patch) is it acceptable ?
Comment #7
radoeka CreditAttribution: radoeka commentedWith the patch in #6 the first tab is moved to the left, and looks not aligned with the rest of the page.
Shouldn't the patch be:
current: padding: 0 15px;
new: padding-left: 15px;
Either way padding 0 15px and padding-left works for me. FF-3.6.12.
The attachment (drupal7-padding.png) shows the result of the different options.
(ps: what to do, to show the image in the comment, is that possible for me?)
Comment #8
JacineSorry, didn't test this in Firefox. My mistake.
@sivaji The padding is not excess. There should be 15px on both the right and the left, so it lines up with everything else.
Here's a patch to fix it.
Comment #9
Damien Tournoud CreditAttribution: Damien Tournoud commentedAh. At last a patch that actually makes sense :)
Comment #10
carlos8f CreditAttribution: carlos8f commentedI think the underlying problem is that in #903460: Bartik Tabs broken in Firefox, Jeff Burnz refactored the Bartik tabs to use "good old-fashioned" floats rather than display:inline, yet we've given the menu the inline class in this issue. I sent the patch through browsershots.org and the tabs are now positioned correctly.
Comment #11
Jacine#10 is fine with me. Works just as well.
Comment #13
carlos8f CreditAttribution: carlos8f commentedAppears that HEAD is still broken.
Comment #14
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.