After enabling the endnote XML module and creating a biblio node, the Endnote download link does not appear.

CommentFileSizeAuthor
#6 954558_5_biblio_endnote.patch1.61 KBscor
#2 954558_2_biblio_endnote.patch1.65 KBscor
#1 954558_1_biblio_endnote.patch1.56 KBscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new 954558_1_biblio_endnote.patch1.56 KB

This patch fixes the array structure in biblio_xml_node_view() and biblio_xml_biblio_export_link().

Also, I think it would make more sense to name the link "Endnote" rather than "XML", XML could be anything, Endnote is more meaningful than XML to researchers too. (I haven't made that change in the patch).

scor’s picture

scor commented
StatusFileSize
new 954558_2_biblio_endnote.patch1.65 KB

better formatting.

rjerome’s picture

rjerome commented

Strange, cause they work just fine on my systems. I wonder if it's a theme issue?

scor’s picture

scor commented

again, as usual, I'm doing all my testing from the fairly fresh D7 installation with the latest biblio for D7. I can reproduce with D7-beta2 on bartik, stark and garland. The patch #2 solves this issue.

rjerome’s picture

rjerome commented

Yep, same here, D7-beta2 and it works fine with all the themes. All the links are constructed in exactly the same fashion, so I don't know why just that one wouldn't work (other that perhaps the XML has some significance to you browser)

Have you tried different browsers?

scor’s picture

scor commented
StatusFileSize
new 954558_5_biblio_endnote.patch1.61 KB

This patch uses a more conservative structure in biblio_xml_biblio_export_link() which otherwise break the biblio listings.

rjerome’s picture

rjerome commented
Status: Needs review » Fixed

committed...

http://drupal.org/cvs?commit=444152

scor’s picture

scor commented

created #958284: Rename endnote download link to something more meaningful than "XML" for the naming of the endnote link.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.