This adds code to skip the format selection step in the WYSIWYG "add media" process, because unlike with images, selecting between "preview", "large", and "original" doesn't make sense: it's all "original", and can be resized with the wysiwyg handles. In the future, selecting between appropriate formatters, like embed, text link, thumbnail link, might be useful: when that's working, we can bring that step back.

This also adds STYLE attributes to the image placeholder within the wysiwyg editor and to a DIV container of the embed tag, so that the video can be resized in wysiwyg and that size used when rendering the video. I dislike STYLE tags in markup, so maybe we can improve that at some point.

CommentFileSizeAuthor
media_youtube-wysiwyg.patch2.51 KBeffulgentsia

Comments

effulgentsia’s picture

effulgentsia commented

I dislike STYLE tags in markup, so maybe we can improve that at some point.

I meant to say I dislike STYLE attributes in markup, but you get the point.

aaron’s picture

aaron commented
Status: Needs review » Postponed

i'm working on this being handled by the styles module, so that you can select between linked thumbnails, title/description combos, etc. let's hold off just a bit till i get that working, then we can revisit this.

JacobSingh’s picture

JacobSingh commented
Status: Postponed » Needs review

@Aaron: Any progress here? DG is running a patched version now since we deployed this functionality. Can we get this in and provide an upgrade path when the styles v2 stuff lands?

aaron’s picture

aaron commented

sorry, jacobsingh, still have more to go. go ahead and get this in so we can get things working; i'll make sure we can do an upgrade path later. (v2 will certainly be more usable, as it has more progress towards a ui).

aaron’s picture

aaron commented
Status: Needs review » Fixed

committed this, sorry for the delay. thanks, effulgentsia!

aspilicious’s picture

aspilicious commented
Status: Fixed » Active

This is working perfect now!

aaron’s picture

aaron commented
Status: Active » Fixed

awesome!

aspilicious’s picture

aspilicious commented

srry for the status change...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.