This module still does not use best practices and needs additional coding standard improvements.

Cheers,

Antoine

CommentFileSizeAuthor
#2 uc_edi-950156_1.patch39.61 KBjantoine
#1 uc_edi-950156.patch33.21 KBjantoine

Comments

jantoine’s picture

Status: Active » Needs review
StatusFileSize
new33.21 KB

Patch attached with the following changes:
- Replaced the uc_edi_get_delimiter() function with a string, no need for function call overhead.
- Replaced the uc_edi_default_order_import_rules() function with a string, no need for function call overhead.
- Changed the $order parameter of the uc_edi_generate_order_export() and uc_edi_generate_order_product_export() functions from an order object to an order object reference for efficiency.
- Replaced the uc_edi_default_order_export_pattern() function with a string, no need for function call overhead.
- Replaced the uc_edi_default_order_product_export_pattern() function with a string, no need for function call overhead.
- Replaced 'uc_edi_order_export_product_line_number' Drupal variable with php variable.
- Replaced the uc_edi_admin_help() function with hook_help().
- Consolidated the uc_edi_order_admin and uc_edi_order_admin_form functions.
- Fixed variable names in the .module file to match that in the .install file.
- General code and comment cleanup.

Cheers,

Antoine

jantoine’s picture

Status: Needs review » Fixed
StatusFileSize
new39.61 KB

Updated the changes against head and committed the attached patch.

Cheers,

Antoine

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.