The link mapper included in the feeds module has not yet been upgraded for Drupal 7. I've upgraded this mapper and have included a patch.

Comments

alex_b’s picture

Status:Needs review» Needs work

- Upgrade tests.
- Add Link module back into Feeds test profile.

tristanoneil’s picture

I've started work on the test fixes however, I noticed the use of the deprecated function split() which I've replaced with preg_split() instead.

tristanoneil’s picture

StatusFileSize
new5.42 KB

I guess it would help if I attached the patch.

tristanoneil’s picture

StatusFileSize
new5.42 KB

In anticipation of a future patch #953728: Upgrade text formats, use on all processors this adds a necessary fourth argument to link_feeds_set_target() to my link mapper patch.

alex_b’s picture

StatusFileSize
new5.49 KB

- Cleaned up type check - no need to use $allowed_types when there is only one allowed type.
- Added //$Id$ line
- Added @file comment

Otherwise looking good.

Let's upgrade the tests before we commit that.

tristanoneil’s picture

StatusFileSize
new9.9 KB

I've added back in the link mapper test and upgraded it for Drupal 7 this patch should be good to go.

tristanoneil’s picture

Status:Needs work» Needs review

Forgot to change the status to needs review.

tristanoneil’s picture

Status:Needs review» Fixed

#7 has been committed http://drupal.org/cvs?commit=445022.

alex_b’s picture

Status:Fixed» Needs work

Great -

Can you get also rid of the reference to CCK - "... for Link CCK fields. Requires CCK and Link module": http://drupalcode.org/viewvc/drupal/contributions/modules/feeds/tests/fe...

tristanoneil’s picture

Status:Needs work» Fixed

I've made this changed and committed it here http://drupal.org/cvs?commit=445072.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.